fix(Scanner): Use time based limit for the transaction#56290
Closed
artonge wants to merge 4 commits into
Closed
Conversation
artonge
requested review from
CarlSchwan,
icewind1991,
leftybournes and
yemkareems
and removed request for
a team
artonge
force-pushed
the
artonge/fix/use_time_limit_in_scanner
branch
from
3f93896 to
ca2607d
Compare
artonge
added
bug
feature: files
php
Collaborator
Author
|
/backport to stable32 |
Collaborator
Author
|
/backport to stable31 |
artonge
force-pushed
the
artonge/fix/use_time_limit_in_scanner
branch
10 times, most recently
from
618bd87 to
d63a245
Compare
Merged
Collaborator
Author
|
/backport! to stable30 |
|
The backport to # Switch to the target branch and update it
git checkout stable30
git pull origin stable30
# Create the new backport branch
git checkout -b backport/56290/stable30
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 8dd6e002 d63a2454
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/56290/stable30Error: Failed to push branch backport/56290/stable30: remote: Invalid username or token. Password authentication is not supported for Git operations. Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
CarlSchwan
approved these changes
Jan 22, 2026
This was referenced Jan 29, 2026
Merged
Merged
Member
|
/backport to stable33 |
Collaborator
Author
|
I think we should keep the max entry to commit limit, so that we have two limits instead of one. I'll try to look into it. |
This was referenced Feb 11, 2026
Merged
Merged
Signed-off-by: Louis Chmn <[email protected]>
artonge
force-pushed
the
artonge/fix/use_time_limit_in_scanner
branch
from
d63a245 to
fed9e42
Compare
icewind1991
reviewed
Apr 2, 2026
icewind1991
approved these changes
Apr 2, 2026
artonge
force-pushed
the
artonge/fix/use_time_limit_in_scanner
branch
3 times, most recently
from
e4a42f3 to
f499ea0
Compare
Using the node count does not help if handling a node is slow. Signed-off-by: Louis Chmn <[email protected]>
Signed-off-by: Louis Chmn <[email protected]>
Signed-off-by: Louis Chmn <[email protected]>
artonge
force-pushed
the
artonge/fix/use_time_limit_in_scanner
branch
from
f499ea0 to
03bfa32
Compare
Collaborator
Author
|
Closing as we will rather remove the transaction all together |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using the node count does not help if handling a node is slow.
This prevent locking the database for unknown amount of time.
10 seconds is arbitrary, but I don't see any reason to no go even lower.