Improve connectivity check#55321
Conversation
Signed-off-by: Côme Chilliet <[email protected]>
…redirection Signed-off-by: Côme Chilliet <[email protected]>
Altahrim
added
the
pending documentation
joshtrichards
left a comment
joshtrichards
left a comment
There was a problem hiding this comment.
Good call.
Maybe add the shuffle just for kicks.
Kind of tempting to put something like https://one.one.one.one/ and/or https://www.speedtest.net/ in here...
| 'https://connectivity.nextcloud.com', 'https://www.eff.org', 'https://edri.org' | ||
| ]); | ||
|
|
||
| foreach ($siteArray as $site) { |
There was a problem hiding this comment.
| foreach ($siteArray as $site) { | |
| shuffle($siteArray); | |
| foreach ($siteArray as $site) { |
There was a problem hiding this comment.
No, we prefer to default to the same one always and avoid random behavior.
|
Might be worth backporting this. It's a quasi-bug fix. It's not really a feature exactly. |
|
Documented in nextcloud/documentation#13719 Anyone in a hurry can just set connectivity.nextcloud.com in the config file at connectivity_check_domains. |
come-nc
removed
the
pending documentation
4 participants
Summary
Current version does a GET on our website, which is heavier than needed, both for our website and the Nextcloud instances.
Changed to a dedicated service and a HEAD request.
Also took the opportunity to remove startpage and correct edri url to avoid a redirection.
Checklist
3. to review, feature component)stable32)