/backport to stable31

@susnux It currently works to upload the CONTENTS of a folder through that menu option. I just tested it, as mentioned in the comment. The issue you link is about preserving folderstructure, which is not required to upload the contents of a folder from the uploaders machine. (many might even expect it to place the files in the root of the share folder)

Or am I missunderstanding?

No, it only uploads (with luck) the top level of the folder. It fails in the MKCOL (make directory) as this is not implemented.
Then the whole upload will be aborted.

Hm, if there's luck involved then that would warrant its removal. But I just tested it with a folder containing 52 files in 22 subfolders with varying nesting - every single file was uploaded - no errors.

Drag and dropping a folder however is completely broken (fails every time). To my understanding this mr does not prevent drag and dropping a folder. In the optimal world drag and drop of a folder is prevented with a small toast/notification that folder upload is not supported as it might be very confusing otherwise (since files can be drag and dropped).

Edit: Im testing with both firefox and ms edge on a linux machine if it matters

Edit2: for me only drag and drop attempts to create folders (it triggers a bunch of "could not create folder" notifications.
Using the menu option does not trigger any, and all files are placed in the root of the shared folder.

Edit3: My browsers even ask me if I want to upload all files from those folders, I also tested a folder containing 1182 files in 57 subfolders of varying nesting, all files were uploaded, no errors. I'm quite confident the menu option works as it should.

32 now allows folder uploads, maybe backport to 31 directly ?

Done

/compile

/compile

The backport to stable31 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable31
git pull origin stable31

# Create the new backport branch
git checkout -b backport/50591/stable31

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 2bb2bbca 361ccc74

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/50591/stable31

Error: Failed to check for changes with origin/stable31: No changes found in backport branch

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.