Merged
Conversation
come-nc
force-pushed
the
fix/move-image-to-oc-namespace
branch
from
17dec99 to
0010f28
Compare
come-nc
requested review from
a team,
artonge,
icewind1991 and
sorbaugh
and removed request for
a team
artonge
reviewed
Aug 28, 2024
artonge
approved these changes
Aug 29, 2024
provokateurin
approved these changes
Aug 29, 2024
Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
come-nc
force-pushed
the
fix/move-image-to-oc-namespace
branch
from
f296d19 to
1f46be7
Compare
Member
|
This broke Talk nextcloud/spreed#13197 and using the OCP replacement does not work. To fix this \OCP\Image needs to implement \OCP\IImage directly and the missing method need to be added to \OCP\IImage. |
This was referenced Sep 2, 2024
come-nc
added
the
pending documentation
Merged
come-nc
removed
the
pending documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Move legacy
OC_Imageinto\OC\Imageand update code style and remove deprecated references in there.This class is exposed through
OCP\Imagewhich is used by applications withnew \OCP\Image()and then\OCP\IImagemethods can be used on it.This still leaves a reference to
OCfromOCPwhich we try to avoid.But this would mean adding an
IImageFactorywhich applications needs to DI, not sure this is worth it.Checklist