Skip to content

Comments

feat(transfer-ownership): Correctly react to encrypted files#47519

Merged
sorbaugh merged 2 commits intomasterfrom
fix/transfer-ownership-encrypted-files
Sep 5, 2024
Merged

feat(transfer-ownership): Correctly react to encrypted files#47519
sorbaugh merged 2 commits intomasterfrom
fix/transfer-ownership-encrypted-files

Conversation

@come-nc
Copy link
Contributor

@come-nc come-nc commented Aug 27, 2024

  • Resolves: #

Summary

  1. For E2EE encrypted files, we abort the transfer.
  2. For SSE encrypted files, we abort only if not using master key.
  3. Also fixed the check for when the path to a single file is used.

Checklist

@come-nc come-nc added bug 3. to review Waiting for reviews labels Aug 27, 2024
@come-nc come-nc added this to the Nextcloud 31 milestone Aug 27, 2024
@come-nc come-nc self-assigned this Aug 27, 2024
@come-nc
Copy link
Contributor Author

come-nc commented Aug 27, 2024

/backport to stable30

@come-nc
Copy link
Contributor Author

come-nc commented Aug 27, 2024

/backport to stable29

@come-nc
Copy link
Contributor Author

come-nc commented Aug 27, 2024

/backport to stable28

@come-nc come-nc requested review from a team, artonge, skjnldsv and yemkareems and removed request for a team August 27, 2024 11:07
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not my area of expertise but the changes make sense and look good

@come-nc come-nc requested a review from artonge September 3, 2024 07:47
For E2EE encrypted files, we abort the transfer.
For SSE encrypted files, we abort only if not using master key.
Also fixed the check for when the path to a single file is used.

Signed-off-by: Côme Chilliet <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants