fix(styles): use also new CSS variable for correct header text color on public pages#46785
Merged
fix(styles): use also new CSS variable for correct header text color on public pages#46785
Conversation
…on public pages Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
changed the title
szaimen
approved these changes
Jul 26, 2024
Contributor
szaimen
left a comment
szaimen
left a comment
There was a problem hiding this comment.
Cool, fixes nextcloud/spreed#12132, I suppose? :)
Contributor
Author
I think so |
skjnldsv
approved these changes
Jul 26, 2024
2 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
primaryandbackgroundcolors - fix the header menu colors #42977Summary
The header text color still is incorrect for public pages if primary color and background color need different text color.
(sorry for the overlay but firefox manages to "screenshot node" while applying their inspection overlay...)
Checklist