Refactors theming app - part 2#45137
Conversation
fsamapoor
force-pushed
the
refactor_theming_app_part2
branch
from
a8d25b3 to
89e69a6
Compare
fsamapoor
requested review from
a team,
ArtificialOwl,
nfebe and
yemkareems
and removed request for
a team
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! |
… property promotion feature. Signed-off-by: Faraz Samapoor <[email protected]>
fsamapoor
force-pushed
the
refactor_theming_app_part2
branch
from
89e69a6 to
11f9ce6
Compare
skjnldsv
added
2. developing
3 participants
Summary
Following previous PRs taking advantage of PHP8's constructor property promotion, I have also made the required adjustments to the classes in the
themingapp.I decided to split the changes into multiple PRs to make reviewing the changes easier.
The improvements in this PR include:
Checklist