Migrate header check to setupcheck API#44067
Conversation
come-nc
force-pushed
the
fix/migrate-header-check-to-setupcheck
branch
4 times, most recently
from
27eee79 to
225cf90
Compare
come-nc
added
3. to review
|
/compile / |
come-nc
requested review from
a team,
Altahrim,
ArtificialOwl,
icewind1991 and
susnux
and removed request for
a team
| ]; | ||
|
|
||
| foreach ($providers as $provider) { | ||
| foreach ($this->runHEAD($this->urlGenerator->getWebroot() . $provider) as $response) { |
There was a problem hiding this comment.
If that is removed, then drop also runHEAD function?
There was a problem hiding this comment.
Still used in other checks I think but yeah we could move all of them.
come-nc
force-pushed
the
fix/migrate-header-check-to-setupcheck
branch
from
1f7d36d to
dd211d0
Compare
|
/compile / |
Altahrim
left a comment
Altahrim
left a comment
There was a problem hiding this comment.
If domain contains only one dot (xxxxx.yyy), we could also advise to use HSTS includeSubDomains and preload (https://hstspreload.org/)
Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
…ementation Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
susnux
force-pushed
the
fix/migrate-header-check-to-setupcheck
branch
from
7b00b81 to
99e967a
Compare
|
/compile amend |
Signed-off-by: nextcloud-command <[email protected]>
nextcloud-command
force-pushed
the
fix/migrate-header-check-to-setupcheck
branch
from
99e967a to
58ae7e4
Compare
Signed-off-by: Côme Chilliet <[email protected]>
I do not have any knowledge about this, I’d say that would be a followup, let’s migrate the feature first. |
4 participants
See #41364
Summary
Security related header check migrated to new API and done from backend now.
TODO:
Checklist