Closed
Conversation
szaimen
force-pushed
the
enh/42998/fix-icon-color
branch
5 times, most recently
from
2c459c5 to
fb6101a
Compare
szaimen
commented
Jan 24, 2024
skjnldsv
reviewed
Jan 24, 2024
Comment on lines
399
to
419
| // Fix wrong color for active icons | ||
| [data-themes*=dark] { | ||
| :deep(.app-navigation-entry.active .app-navigation-entry-icon) { | ||
| filter: var(--primary-invert-if-bright); | ||
| } | ||
| } | ||
| [data-themes*=light] { | ||
| :deep(.app-navigation-entry.active .app-navigation-entry-icon) { | ||
| filter: var(--primary-invert-if-dark); | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
Here you go @szaimen
Suggested change
| // Fix wrong color for active icons | |
| [data-themes*=dark] { | |
| :deep(.app-navigation-entry.active .app-navigation-entry-icon) { | |
| filter: var(--primary-invert-if-bright); | |
| } | |
| } | |
| [data-themes*=light] { | |
| :deep(.app-navigation-entry.active .app-navigation-entry-icon) { | |
| filter: var(--primary-invert-if-dark); | |
| } | |
| } | |
| // Fix wrong color for active icons | |
| @media (prefers-color-scheme: dark) { body { | |
| .app-navigation-entry.active .app-navigation-entry-icon { | |
| filter: var(--primary-invert-if-bright); | |
| } | |
| }} | |
| @media (prefers-color-scheme: light) { body { | |
| .app-navigation-entry.active .app-navigation-entry-icon { | |
| filter: var(--primary-invert-if-dark); | |
| } | |
| }} | |
| [data-themes*=dark] { | |
| .app-navigation-entry.active .app-navigation-entry-icon { | |
| filter: var(--primary-invert-if-bright); | |
| } | |
| } | |
| [data-themes*=light] { | |
| .app-navigation-entry.active .app-navigation-entry-icon { | |
| filter: var(--primary-invert-if-dark); | |
| } | |
| } | |
Contributor
Author
There was a problem hiding this comment.
I just tested this and it doesnt seem to work. Maybe gecause the scss is scoped? :/
Member
There was a problem hiding this comment.
Yes, you need to keep the :deep(, I tested it live, locally, so it worked for me.
Contributor
Author
There was a problem hiding this comment.
I see. Where exactly would I need to put the :deep( ?
Contributor
Author
There was a problem hiding this comment.
This doesnt seem to make it work unfortunately 😢
szaimen
force-pushed
the
enh/42998/fix-icon-color
branch
from
1d46ef0 to
a72a59e
Compare
Signed-off-by: Simon L <[email protected]> Co-Authored-By: John Molakvoæ <[email protected]>
szaimen
force-pushed
the
enh/42998/fix-icon-color
branch
from
a72a59e to
31921ac
Compare
Signed-off-by: Simon L <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #42998
For my own testing