Skip to content

Comments

feat(files): migrate template picker#40854

Merged
skjnldsv merged 1 commit intomasterfrom
fix/template-picker
Oct 17, 2023
Merged

feat(files): migrate template picker#40854
skjnldsv merged 1 commit intomasterfrom
fix/template-picker

Conversation

@skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Oct 10, 2023 •
edited
Loading

Ref: #39914

image

@skjnldsv skjnldsv self-assigned this Oct 10, 2023
@skjnldsv skjnldsv added this to the Nextcloud 28 milestone Oct 10, 2023
@skjnldsv skjnldsv mentioned this pull request Oct 10, 2023
Closed
26 tasks
@skjnldsv skjnldsv force-pushed the fix/template-picker branch from 82bee57 to 6637032 Compare October 12, 2023 06:27
@skjnldsv skjnldsv requested review from a team, juliusknorr, nfebe, sorbaugh and szaimen and removed request for a team October 12, 2023 06:27
@skjnldsv skjnldsv added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Oct 12, 2023
@skjnldsv skjnldsv marked this pull request as ready for review October 12, 2023 06:27
@skjnldsv skjnldsv force-pushed the fix/template-picker branch 2 times, most recently from b67a28c to e6f4d4f Compare October 12, 2023 06:44
@juliusknorr
Copy link
Member

juliusknorr commented Oct 12, 2023 •
edited by skjnldsv
Loading

  • Should also trigger the inline name editing after the file was created?
  • I feel like we should still open the file directly after creating (as it used to be before) but not sure how easy that is to trigger after entering the name

@skjnldsv
Copy link
Member Author

skjnldsv commented Oct 12, 2023

  • Should also trigger the inline name editing after the file was created?

Absolutely!

I feel like we should still open the file directly after creating (as it used to be before) but not sure how easy that is to trigger after entering the name

Good point too! Can I do a followup? :)

@skjnldsv skjnldsv mentioned this pull request Oct 17, 2023
Merged
@skjnldsv
Copy link
Member Author

skjnldsv commented Oct 17, 2023

Ping everyone!

@skjnldsv skjnldsv requested a review from artonge October 17, 2023 06:16
@skjnldsv skjnldsv force-pushed the fix/template-picker branch from e6f4d4f to 0b654a5 Compare October 17, 2023 06:30
artonge
artonge approved these changes Oct 17, 2023
View reviewed changes
@skjnldsv skjnldsv force-pushed the fix/template-picker branch from 0b654a5 to 4b55594 Compare October 17, 2023 09:17
@skjnldsv skjnldsv merged commit 2887e64 into master Oct 17, 2023
@skjnldsv skjnldsv deleted the fix/template-picker branch October 17, 2023 09:17
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 17, 2023
@joshtrichards joshtrichards mentioned this pull request Dec 31, 2023
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@juliusknorr juliusknorr juliusknorr approved these changes

@artonge artonge artonge approved these changes

@nfebe nfebe Awaiting requested review from nfebe nfebe is a code owner automatically assigned from nextcloud/server-frontend

@szaimen szaimen Awaiting requested review from szaimen szaimen is a code owner automatically assigned from nextcloud/server-frontend

@sorbaugh sorbaugh Awaiting requested review from sorbaugh sorbaugh is a code owner automatically assigned from nextcloud/server-frontend

Assignees

@skjnldsv skjnldsv

Labels

4. to release Ready to be released and/or waiting for tests to finish enhancement

Projects

Files to vue
Status: Done

Milestone

Nextcloud 28

Development

Successfully merging this pull request may close these issues.

3 participants

@skjnldsv @juliusknorr @artonge