feat: Allow to configure the app menu order in the frontend by susnux · Pull Request #40844 · nextcloud/server

susnux · 2023-10-09T22:34:23Z

Resolves: ↔️ Make app order configurable #4917
Resolves: ↔️ User-configurable app order #40241
Resolves: ↔️ Create a mockup for the settings-block under "Appearance and accessibility" #40245
Resolves: ↔️ Implement the settings-block (frontend) and persist. #40255

Summary

Front end of the app ordering feature.

This allows to define the app order in the main menu bar on a per-user basis (backend see #40617 ).

Screencast

vokoscreenNG-2023-10-10_00-26-05.mp4

If the admin set up a default app, it will be shown as the first list element but the user can not modify it:

Checklist

Code is properly formatted
Sign-off message is added to all commits
Tests (unit, integration, api and/or acceptance) are included
Screenshots before/after for front-end changes
Documentation (manuals or wiki) has been updated or is not required
Backports requested where applicable (ex: critical bugfixes)

apps/theming/lib/Listener/BeforePreferenceListener.php

lib/private/NavigationManager.php

come-nc

It is now working perfectly.
The json version in the setting switched to string keys, not sure if intended?
It’s not a big deal as for PHP JSON objects and arrays are the same thing. I just noticed [1] became {"0":1}

lib/private/NavigationManager.php

szaimen

Tested and seems to generally work fine and generally looks good from design perspective. However some small remarks. See below

apps/theming/src/components/AppOrderSelectorElement.vue

apps/theming/src/components/UserAppMenuSection.vue

apps/theming/src/components/admin/AppMenuSection.vue

skjnldsv

Works fine, but:

When keyboard-navigating, clicking an arrow loses focus. We should keep the focus to one of those items
There is no way to reset the default order (nor to know the initial order)

szaimen

LGTM from design perspective :)

susnux · 2023-10-19T20:03:05Z

When keyboard-navigating, clicking an arrow loses focus. We should keep the focus to one of those items

There is no way to reset the default order (nor to know the initial order)

Will do so in a follow up as this PR is already to crowded.

…lobal default apps Signed-off-by: Ferdinand Thiessen <[email protected]>

Signed-off-by: Ferdinand Thiessen <[email protected]>

…end settings * Also add API for setting the value using ajax. * Add cypress tests for app order and defaul apps Signed-off-by: Ferdinand Thiessen <[email protected]>

Signed-off-by: Ferdinand Thiessen <[email protected]>

ichier · 2024-02-20T22:25:08Z

When keyboard-navigating, clicking an arrow loses focus. We should keep the focus to one of those items

There is no way to reset the default order (nor to know the initial order)

Will do so in a follow up as this PR is already to crowded.

its great that all this has been adressed! thanx! works like a charm.
and its a nice feature, that even users can do it. but way more important is, that admins can set up a reasonable default that makes sense. (Only powerusers sort stuff themselves, normal people suffer from bad to memorize UI.)
i'm now migrating to 28 (after just having it tested) and i can initially set our previous apporder for all users via SQL. but i don't wanna do it manually for every new user that might come.
would be great if added! i personally don't need UI for that, config.php would be just fine. (and should be quite simple then?)

susnux · 2024-02-20T22:28:46Z

@ichier feel free to open a feature request issue here to keep that tracked.

BTW the two points you quoted are resolved.

Felitendo · 2025-02-25T22:21:39Z

@susnux this is great, but is there also a way to change the default order for every nextcloud user? I would really need this feature

susnux · 2025-03-01T19:10:05Z

@Felitendo as you can read one comment above - no there is no way for a admin defined default, you can make this part of your provisioning process.
Feel free to open a feature request though.

susnux added enhancement 3. to review Waiting for reviews feature: settings ❄️ 2023-Winter labels Oct 9, 2023

susnux added this to the Nextcloud 28 milestone Oct 9, 2023

susnux requested review from Pytal, come-nc, sorbaugh and szaimen October 9, 2023 22:34

susnux mentioned this pull request Oct 9, 2023

[frontend] Add possibility to set default app #40600

Closed

4 tasks

github-advanced-security bot found potential problems Oct 9, 2023

View reviewed changes

apps/theming/lib/Listener/BeforePreferenceListener.php Fixed Show fixed Hide fixed

apps/theming/lib/Listener/BeforePreferenceListener.php Fixed Show fixed Hide fixed

susnux force-pushed the feat/frontend-apporder-default-apps branch 2 times, most recently from 86adea6 to cb7c6f7 Compare October 10, 2023 08:58

This comment was marked as resolved.

Sign in to view

susnux force-pushed the feat/frontend-apporder-default-apps branch 2 times, most recently from 8cf1bee to 63facca Compare October 10, 2023 12:51

susnux requested a review from come-nc October 10, 2023 12:52

github-advanced-security bot found potential problems Oct 10, 2023

View reviewed changes

lib/private/NavigationManager.php Fixed Show fixed Hide fixed

susnux force-pushed the feat/frontend-apporder-default-apps branch from 63facca to 8bf4056 Compare October 10, 2023 13:11

come-nc reviewed Oct 10, 2023

View reviewed changes

susnux force-pushed the feat/frontend-apporder-default-apps branch from 8bf4056 to f35a2e6 Compare October 10, 2023 23:11

github-advanced-security bot found potential problems Oct 10, 2023

View reviewed changes

lib/private/NavigationManager.php Fixed Show fixed Hide fixed

susnux force-pushed the feat/frontend-apporder-default-apps branch from f35a2e6 to 6b8f6d4 Compare October 10, 2023 23:21

susnux requested a review from come-nc October 10, 2023 23:21

susnux force-pushed the feat/frontend-apporder-default-apps branch 2 times, most recently from b5dbfb0 to 9365bb1 Compare October 11, 2023 12:27

come-nc approved these changes Oct 12, 2023

View reviewed changes

szaimen reviewed Oct 12, 2023

View reviewed changes

apps/theming/src/components/AppOrderSelectorElement.vue Outdated Show resolved Hide resolved

apps/theming/src/components/UserAppMenuSection.vue Outdated Show resolved Hide resolved

apps/theming/src/components/admin/AppMenuSection.vue Outdated Show resolved Hide resolved

susnux requested a review from szaimen October 18, 2023 00:15

susnux force-pushed the feat/frontend-apporder-default-apps branch from 9365bb1 to bed8dfb Compare October 18, 2023 00:15

susnux requested a review from skjnldsv October 18, 2023 00:15

skjnldsv approved these changes Oct 18, 2023

View reviewed changes

szaimen approved these changes Oct 18, 2023

View reviewed changes

susnux added 2 commits October 19, 2023 22:04

feat(IAppManager): Allow to set the (user) default apps and get all g…

08cff07

…lobal default apps Signed-off-by: Ferdinand Thiessen <[email protected]>

feat(NavigationManager): Always sort the default app first

363d9eb

Signed-off-by: Ferdinand Thiessen <[email protected]>

susnux force-pushed the feat/frontend-apporder-default-apps branch from bed8dfb to 8cbb345 Compare October 19, 2023 20:17

susnux added 2 commits October 20, 2023 00:24

feat(theming): Allow to configure default apps and app order in front…

e9d4036

…end settings * Also add API for setting the value using ajax. * Add cypress tests for app order and defaul apps Signed-off-by: Ferdinand Thiessen <[email protected]>

chore: Compile assets

f3f3f4c

Signed-off-by: Ferdinand Thiessen <[email protected]>

susnux force-pushed the feat/frontend-apporder-default-apps branch from 8cbb345 to f3f3f4c Compare October 19, 2023 22:24

susnux merged commit 06327be into master Oct 19, 2023

susnux deleted the feat/frontend-apporder-default-apps branch October 19, 2023 22:54

susnux mentioned this pull request Oct 20, 2023

theming: Allow to reset custom app order and keep focus when reordering #41024

Merged

4 tasks

nextcloud locked as resolved and limited conversation to collaborators Mar 1, 2025

Uh oh!

Comments

Conversation

susnux commented Oct 9, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Screencast

Checklist

Uh oh!

Uh oh!

Uh oh!

This comment was marked as resolved.

Uh oh!

Uh oh!

come-nc left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

szaimen left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

skjnldsv left a comment • edited by susnux Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

szaimen left a comment

Choose a reason for hiding this comment

Uh oh!

susnux commented Oct 19, 2023 • edited by skjnldsv Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ichier commented Feb 20, 2024

Uh oh!

susnux commented Feb 20, 2024

Uh oh!

Felitendo commented Feb 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

susnux commented Mar 1, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

susnux commented Oct 9, 2023 •

edited

Loading

skjnldsv left a comment •

edited by susnux

Loading

susnux commented Oct 19, 2023 •

edited by skjnldsv

Loading

Felitendo commented Feb 25, 2025 •

edited

Loading