refactor(f2v): Migrate unread comments action to the new FileAction API#40409
Merged
refactor(f2v): Migrate unread comments action to the new FileAction API#40409
Conversation
lhsazevedo
added
3. to review
skjnldsv
approved these changes
Sep 16, 2023
skjnldsv
requested review from
a team,
Pytal,
artonge and
susnux
and removed request for
a team
Member
Maybe, I don't recall. We'll see if that causes issues later on! Let get this merged :) |
AndyScherzinger
approved these changes
Sep 16, 2023
skjnldsv
force-pushed
the
feat/f2v-unread-comments-action
branch
from
dd2a85e to
3791adf
Compare
Member
|
/compile amend / |
skjnldsv
force-pushed
the
feat/f2v-unread-comments-action
branch
from
3791adf to
6bfd91e
Compare
skjnldsv
added
4. to release
Signed-off-by: Lucas Azevedo <[email protected]>
skjnldsv
force-pushed
the
feat/f2v-unread-comments-action
branch
from
6bfd91e to
03ece12
Compare
icewind1991
approved these changes
Sep 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrate inline unread comments action to the new FileAction API.
To display the inline action as a icon only button, I had to remove the
force-nameprop from the<NcActions />in theFileEntry.vue, otherwise theNcButtonis rendered with text as well. But I imagine the action buttons were meant to be icon only, so I guess this was unintentionally added?Screenshots
TODO
Vue.set()to overwrite thecomments-unreadattribute and rely on reactivity to disable the action?Checklist
Documentation (manuals or wiki) has been updated or is not requiredBackports requested where applicable (ex: critical bugfixes)