Skip to content

Comments

feat(files): add drag and drop support#39998

Merged
skjnldsv merged 4 commits intomasterfrom
feat/f2v/dnd
Sep 26, 2023
Merged

feat(files): add drag and drop support#39998
skjnldsv merged 4 commits intomasterfrom
feat/f2v/dnd

Conversation

@skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Aug 22, 2023 •
edited
Loading

Informations

This PR adds drag and dro psupport for files

Bug

  • The loading indicator seems broken, this is a vue reactivity issue that will be fixed later, this is not related to this PR :)

Ref #39914

Fix #18850
Fix #37658
Fix #5356

  • Move mechanism (bind to the move action?)
  • Visual feedback

@skjnldsv skjnldsv added this to the Nextcloud 28 milestone Aug 22, 2023
@skjnldsv skjnldsv self-assigned this Aug 22, 2023
@skjnldsv skjnldsv mentioned this pull request Aug 24, 2023
Closed
26 tasks
@skjnldsv
Copy link
Member Author

skjnldsv commented Sep 5, 2023

@nextcloud/designers I'm close to finish this and a question popped up. When selecting a big set of files and folder, maybe it would be safe to have an alert and ask confirmation before drag-dropping to another folder? Because we currently have no cancellation button, so if you misclick and drop to another folder, might have bad outcomes? 🤔

@marcoambrosini
Copy link
Member

marcoambrosini commented Sep 14, 2023

When selecting a big set of files and folder, maybe it would be safe to have an alert and ask confirmation before drag-dropping to another folder?

@skjnldsv Without a toggle for this in the settings, I'm afraid this could get in the way of people who are sure about what they're doing

@skjnldsv skjnldsv force-pushed the feat/f2v/dnd branch 2 times, most recently from cee3ab2 to 7b59fa3 Compare September 22, 2023 08:38
@skjnldsv skjnldsv added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Sep 22, 2023
@skjnldsv
Copy link
Member Author

skjnldsv commented Sep 22, 2023 •
edited
Loading

@skjnldsv Without a toggle for this in the settings, I'm afraid this could get in the way of people who are sure about what they're doing

When dragging 100+ files, any confirmation is better than a potential destructive outcome, no? cc @jancborchardt

@skjnldsv skjnldsv marked this pull request as ready for review September 23, 2023 09:24
@skjnldsv skjnldsv requested a review from lhsazevedo September 23, 2023 14:20
artonge
artonge reviewed Sep 25, 2023
View reviewed changes
@skjnldsv skjnldsv force-pushed the feat/f2v/dnd branch 2 times, most recently from 3ee3360 to df8e040 Compare September 26, 2023 12:21
@skjnldsv skjnldsv requested a review from artonge September 26, 2023 12:21
@skjnldsv
fix(files): preview loading
e3b2af4 
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
@skjnldsv skjnldsv merged commit d395fa8 into master Sep 26, 2023
@delete-merged-branch delete-merged-branch bot deleted the feat/f2v/dnd branch September 26, 2023 18:33
@starypatyk starypatyk mentioned this pull request Oct 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@susnux susnux susnux approved these changes

@artonge artonge artonge approved these changes

@Pytal Pytal Awaiting requested review from Pytal

@szaimen szaimen Awaiting requested review from szaimen szaimen is a code owner

@lhsazevedo lhsazevedo Awaiting requested review from lhsazevedo

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl is a code owner

@come-nc come-nc Awaiting requested review from come-nc come-nc is a code owner

@icewind1991 icewind1991 Awaiting requested review from icewind1991 icewind1991 is a code owner

@nfebe nfebe Awaiting requested review from nfebe nfebe is a code owner

Assignees

@skjnldsv skjnldsv

Labels

3. to review Waiting for reviews enhancement feature: files

Projects

Files to vue
Status: Done

Milestone

Nextcloud 28

4 participants

@skjnldsv @marcoambrosini @susnux @artonge