Skip to content

Comments

Create new file/folder labels#37929

Merged
juliusknorr merged 1 commit intomasterfrom
enh/a11y-create-new-label
Apr 27, 2023
Merged

Create new file/folder labels#37929
juliusknorr merged 1 commit intomasterfrom
enh/a11y-create-new-label

Conversation

@Pytal
Copy link
Member

@Pytal Pytal commented Apr 26, 2023

Summary

Add labels for the submit buttons
image

TODO

  • Files view
  • Public files editable view

Related

Checklist

@Pytal Pytal added the 2. developing Work in progress label Apr 26, 2023
@Pytal Pytal self-assigned this Apr 26, 2023
@Pytal Pytal force-pushed the enh/a11y-create-new-label branch from c731f22 to 71d84c6 Compare April 27, 2023 02:46
@Pytal Pytal changed the title [WIP] New file/folder menu labels Create new file/folder labels Apr 27, 2023
@Pytal Pytal marked this pull request as ready for review April 27, 2023 02:55
@Pytal Pytal added this to the Nextcloud 27 milestone Apr 27, 2023
@Pytal Pytal added 3. to review Waiting for reviews feature: files accessibility and removed 2. developing Work in progress labels Apr 27, 2023
@Pytal
Copy link
Member Author

Pytal commented Apr 27, 2023

/compile amend /

Signed-off-by: Christopher Ng <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
@nextcloud-command nextcloud-command force-pushed the enh/a11y-create-new-label branch from 71d84c6 to 966bc06 Compare April 27, 2023 03:20
@juliusknorr
Copy link
Member

Failure unrelated

@juliusknorr juliusknorr merged commit 2646fd5 into master Apr 27, 2023
@juliusknorr juliusknorr deleted the enh/a11y-create-new-label branch April 27, 2023 07:06
@artonge
Copy link
Contributor

artonge commented Apr 27, 2023

This breaks master when no $actionLabel is set. Should we have a default value for it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants