feat(files): add default action support and expose router#37824
Merged
feat(files): add default action support and expose router#37824
Conversation
artonge
reviewed
Apr 19, 2023
1 task
Member
|
I'd highly prefer a simple wrapper around the Vue router. It potentially makes upgrades and the migration away from the Vue router easier. Todays fancy tech will be legacy one day. |
Signed-off-by: John Molakvoæ <[email protected]>
Signed-off-by: John Molakvoæ <[email protected]>
skjnldsv
force-pushed
the
feat/groupfolders
branch
from
517f2fa to
0a2a1b4
Compare
skjnldsv
added
3. to review
Member
Author
|
Done, the router is implemented, see first comment |
artonge
approved these changes
Apr 20, 2023
ChristophWurst
approved these changes
Apr 20, 2023
Member
ChristophWurst
left a comment
ChristophWurst
left a comment
There was a problem hiding this comment.
Looks good
Docs needed for the new OCP.Files.Router API
ChristophWurst
added
the
pending documentation
skjnldsv
added
4. to release
skjnldsv
removed
the
pending documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds default action support
This means any default action not being bound to the file name click will be shown in the actions menu (so far there is none). But that means we could have
Open in Vieweras default andOpen in Collabora... etc in the menu 🚀Reference: nextcloud/viewer#2393
Expose vue router to allow external apps to change the route
Example:
Required for nextcloud/groupfolders#2326