feat(SpeechToText): Add SpeechToText OCP provider API#37674
Merged
nickvergessen merged 26 commits intomasterfrom Apr 19, 2023
Merged
feat(SpeechToText): Add SpeechToText OCP provider API#37674nickvergessen merged 26 commits intomasterfrom
nickvergessen merged 26 commits intomasterfrom
Conversation
Signed-off-by: Marcel Klehr <[email protected]>
Signed-off-by: Marcel Klehr <[email protected]>
Signed-off-by: Marcel Klehr <[email protected]>
Signed-off-by: Marcel Klehr <[email protected]>
marcelklehr
changed the title
juliusknorr
reviewed
Apr 12, 2023
… path Signed-off-by: Marcel Klehr <[email protected]>
marcelklehr
commented
Apr 12, 2023
nickvergessen
requested changes
Apr 12, 2023
Signed-off-by: Marcel Klehr <[email protected]>
Signed-off-by: Marcel Klehr <[email protected]>
Signed-off-by: Marcel Klehr <[email protected]>
nickvergessen
requested changes
Apr 13, 2023
Co-authored-by: Joas Schilling <[email protected]> Signed-off-by: Marcel Klehr <[email protected]>
marcelklehr
commented
Apr 13, 2023
Signed-off-by: Marcel Klehr <[email protected]>
Signed-off-by: Marcel Klehr <[email protected]>
Signed-off-by: Marcel Klehr <[email protected]>
Co-authored-by: Joas Schilling <[email protected]> Signed-off-by: Marcel Klehr <[email protected]>
nickvergessen
approved these changes
Apr 17, 2023
nickvergessen
added
enhancement
pending documentation
Signed-off-by: Joas Schilling <[email protected]>
nickvergessen
added
3. to review
Co-authored-by: Julien Veyssier <[email protected]> Signed-off-by: Marcel Klehr <[email protected]>
Signed-off-by: Marcel Klehr <[email protected]>
…e file Signed-off-by: Marcel Klehr <[email protected]>
Signed-off-by: Marcel Klehr <[email protected]>
…d expose them on the Transcription*Events Signed-off-by: Marcel Klehr <[email protected]>
Signed-off-by: Marcel Klehr <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
nickvergessen
approved these changes
Apr 19, 2023
Signed-off-by: Joas Schilling <[email protected]>
julien-nc
approved these changes
Apr 19, 2023
Member
Author
|
Documentation pending. Working on it right now. |
Member
Author
|
Documentation pr: nextcloud/documentation#10085 |
ChristophWurst
removed
the
pending documentation
Member
Author
|
woop woop. thanks @nickvergessen for helping me with this! |
Member
|
Don't forget to add an entry in #37039 referencing this PR and the documentation page |
Member
Author
|
Isn't #37039 only for (breaking) changes? I didn't know we also add additions there, that's also why I didn't add the translations API there. Will add this, though. |
Member
Yeah I complained about this already. No, it used to be breaking changes only, but now it's basically the OCP changelog. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implement an OCP API register and call SpeechToText providers
Checklist