Conversation
juliusknorr
force-pushed
the
enh/app-menu-vue
branch
from
b4a0796 to
1721afe
Compare
juliusknorr
requested review from
a team,
CarlSchwan,
PVince81,
Pytal,
artonge,
skjnldsv and
szaimen
and removed request for
a team
juliusknorr
added
3. to review
|
The focus frame is now touching the border of the header, causing some contrast issue since there is no clear separation between the focus frame and outside the focus frame.
|
|
@juliushaertl would it be possible to add an API for re-ordering the apps or hiding some of them? I am thinking about the apporder app that will probably break after this PR... |
Possible yes, but not planned yet. There is some long discussion about this in #4917 |
juliusknorr
force-pushed
the
enh/app-menu-vue
branch
from
95b1f88 to
ffc251b
Compare
|
@CarlSchwan Addressed :) |
juliusknorr
force-pushed
the
enh/app-menu-vue
branch
from
eed160f to
ca43271
Compare
juliusknorr
added
the
4. to release
|
there are JS test failures related to snap/snapper that need to be adjusted |
Signed-off-by: Daniel Calviño Sánchez <[email protected]>
|
Thanks @danxuliu ❤️ |
There was a problem hiding this comment.
Some details:
- The active indicator is a bit low down, would be nice if it’s visually inbetween the icon and the content. Just a few px further up :)
- With a light background selected from the Dashboard, is the same logic of making the header bar icons dark, so they are visible?
- As per the video, the focus effect is still overlapping the text, or is the vid outdated, as in @CarlSchwan’s comment it also looked different?
Something we can do once the background image is a global option: #33733
I didn't touch that yet, to first get the major change in, still tracked as open in #33741
Will adjust. |
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
|
|
||
| const breakpointMobileWidth = getComputedStyle(document.documentElement).getPropertyValue('--breakpoint-mobile') | ||
| // keep in sync with core/css/variables.scss | ||
| const breakpointMobileWidth = 1024 |
There was a problem hiding this comment.
not sure about this... yet another place where we need to maintain this number...
There was a problem hiding this comment.
This is breaking the jsunit tests it seems, so I only reverted to the previous state. Something to look into at some later point.
|
Failure unrelated |
Which was removed in the Vue rewrite in #33728. This breaks things like nextcloud/external#79 Signed-off-by: Thomas Citharel <[email protected]>
Which was removed in the Vue rewrite in #33728. This breaks things like nextcloud/external#79 Signed-off-by: Thomas Citharel <[email protected]> Signed-off-by: nextcloud-command <[email protected]>
Which was removed in the Vue rewrite in #33728. This breaks things like nextcloud/external#79 Signed-off-by: Thomas Citharel <[email protected]> Signed-off-by: nextcloud-command <[email protected]>
Which was removed in the Vue rewrite in #33728. This breaks things like nextcloud/external#79 Signed-off-by: Thomas Citharel <[email protected]> Signed-off-by: nextcloud-command <[email protected]>
Which was removed in the Vue rewrite in #33728. This breaks things like nextcloud/external#79 Signed-off-by: Thomas Citharel <[email protected]>
Which was removed in the Vue rewrite in #33728. This breaks things like nextcloud/external#79 Signed-off-by: Thomas Citharel <[email protected]>
Which was removed in the Vue rewrite in #33728. This breaks things like nextcloud/external#79 Signed-off-by: Thomas Citharel <[email protected]>
Which was removed in the Vue rewrite in #33728. This breaks things like nextcloud/external#79 Signed-off-by: Thomas Citharel <[email protected]>
Which was removed in the Vue rewrite in nextcloud#33728. This breaks things like nextcloud/external#79 Signed-off-by: Thomas Citharel <[email protected]> Signed-off-by: Akhil <[email protected]>
10 participants
Move app menu to vue in preparation for further adjustments of #33568
Screen.Recording.2022-08-29.at.19.25.07.mov