Hide preview if it is in full screen mode (viewer is open)#31408
Merged
Hide preview if it is in full screen mode (viewer is open)#31408
Conversation
Signed-off-by: Julius Härtl <[email protected]>
juliusknorr
added
enhancement
design
juliusknorr
requested review from
jancborchardt,
luka-nextcloud,
max-nextcloud,
skjnldsv and
vinicius73
This was referenced Mar 2, 2022
skjnldsv
approved these changes
Mar 2, 2022
Member
skjnldsv
left a comment
skjnldsv
left a comment
There was a problem hiding this comment.
Nice! Definitely a regression! 🚀
skjnldsv
added
4. to release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR hides the sidebar preview image if a file is opened in the viewer (alias fullscreen mode in the viewer/sidebar code base). In those cases it will fall back to the compact mode to avoid having a thumbnail next to the actual file which is already displayed.
Screenshots from text, but this applies to all file types that use viewer:
Before
After
This came up in multiple discussions with @jancborchardt and I think at some point it was already the case with older Nextcloud versions.