Skip to content

Comments

the user always may modify their additional emails#28828

Merged
Pytal merged 2 commits intomasterfrom
fix/noid/additional-mails-editable
Sep 15, 2021
Merged

the user always may modify their additional emails#28828
Pytal merged 2 commits intomasterfrom
fix/noid/additional-mails-editable

Conversation

@blizzz
Copy link
Member

@blizzz blizzz commented Sep 14, 2021

allow_user_to_change_display_name is supposed to only lock the display name and system mail address.

@blizzz blizzz added bug 3. to review Waiting for reviews labels Sep 14, 2021
@blizzz blizzz added this to the Nextcloud 23 milestone Sep 14, 2021
@blizzz blizzz requested review from Pytal and skjnldsv September 14, 2021 13:50
@blizzz
Copy link
Member Author

blizzz commented Sep 14, 2021

/compile /apps/settings

@blizzz
Copy link
Member Author

blizzz commented Sep 14, 2021

/backport to stable22

@blizzz blizzz requested review from a team and julien-nc and removed request for a team September 14, 2021 13:53
@nextcloud-command
Compile assets
1e28d14 
Signed-off-by: nextcloud-command <[email protected]>
szaimen
szaimen reviewed Sep 14, 2021
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose after this change is there no way anymore to disable changing mail addresses?

julien-nc
julien-nc approved these changes Sep 14, 2021
View reviewed changes
Copy link
Member

@julien-nc julien-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

allow_user_to_change_display_name is supposed to only lock the display name and system mail address.

I trust you on that even if it's kind of strange that is has an effect on the system mail address.

Code looks good.

@blizzz
Copy link
Member Author

blizzz commented Sep 14, 2021

I trust you on that even if it's kind of strange that is has an effect on the system mail address.

yeah the name of this setting is misleading

@blizzz
Copy link
Member Author

blizzz commented Sep 14, 2021

I suppose after this change is there no way anymore to disable changing mail addresses?

The system email address maybe changed or not. Either by this configuration flag (allow_user_to_change_display_name), or mails from LDAP are read only, for instance.

But the additional email addresses work independent from it, are user controlled and can always be set. The latter was not possible for it was part of that generic if-statement.

@szaimen
Copy link
Contributor

szaimen commented Sep 14, 2021 •
edited
Loading

I suppose after this change is there no way anymore to disable changing mail addresses?

The system email address maybe changed or not. Either by this configuration flag (allow_user_to_change_display_name)

But the additional email addresses work independent from it, are user controlled and can always be set. The latter was not possible for it was part of that generic if-statement.

Fine by me then 👍

@blizzz blizzz mentioned this pull request Sep 14, 2021
Merged
4 tasks
@Pytal Pytal merged commit db00014 into master Sep 15, 2021
@Pytal Pytal deleted the fix/noid/additional-mails-editable branch September 15, 2021 01:22
@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Sep 15, 2021
@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Sep 15, 2021

The backport to stable22 failed. Please do this backport manually.

@blizzz blizzz mentioned this pull request Sep 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@julien-nc julien-nc julien-nc approved these changes

@Pytal Pytal Pytal approved these changes

@szaimen szaimen szaimen approved these changes

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees

No one assigned

Labels

4. to release Ready to be released and/or waiting for tests to finish bug

Projects

None yet

Milestone

Nextcloud 23

Development

Successfully merging this pull request may close these issues.

6 participants

@blizzz @szaimen @julien-nc @Pytal @skjnldsv @nextcloud-command