Skip to content

Comments

Reply with json when not accepting html on LoginException#26846

Merged
MorrisJobke merged 2 commits intomasterfrom
followup/26572/reply-with-json-when-not-accepting-html
May 17, 2021
Merged

Reply with json when not accepting html on LoginException#26846
MorrisJobke merged 2 commits intomasterfrom
followup/26572/reply-with-json-when-not-accepting-html

Conversation

@nickvergessen
Copy link
Member

Follow up to #26572

Copy link
Member

@korelstar korelstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the problem. Thanks for the quick response!

Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense 👍

Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline

@nickvergessen nickvergessen requested a review from MorrisJobke May 3, 2021 14:14
@korelstar
Copy link
Member

Ping @MorrisJobke
I'm looking forward for getting this merged :-)

@nickvergessen nickvergessen force-pushed the followup/26572/reply-with-json-when-not-accepting-html branch from e779eb6 to 236f1b6 Compare May 12, 2021 06:03
@nickvergessen nickvergessen requested a review from MorrisJobke May 12, 2021 06:06
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with me 👍

@MorrisJobke MorrisJobke merged commit 77a4368 into master May 17, 2021
@MorrisJobke MorrisJobke deleted the followup/26572/reply-with-json-when-not-accepting-html branch May 17, 2021 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants