Register service aliases und parameters just once#25786
Merged
ChristophWurst merged 1 commit intomasterfrom Feb 25, 2021
Merged
Register service aliases und parameters just once#25786ChristophWurst merged 1 commit intomasterfrom
ChristophWurst merged 1 commit intomasterfrom
Conversation
Signed-off-by: Christoph Wurst <[email protected]>
Member
Author
|
@axheli @TomasTokaMrazek @klou @amatteo78 please test |
ChristophWurst
added
3. to review
Member
Author
|
/backport to stable21 |
szaimen
approved these changes
Feb 24, 2021
Contributor
szaimen
left a comment
szaimen
left a comment
There was a problem hiding this comment.
I've applied the fix and can confirm that the fix works 👍
nickvergessen
approved these changes
Feb 25, 2021
Member
|
PHP CS complains? |
Member
Author
but somewhere else 🤷 |
Member
Author
I think because of #24978 |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #24711
Leftover of #24164
So basically what happened is that registration is run for all enabled apps, all the things are delegated and cleaned up but not the aliases and params. Then a new app gets enabled, we do async registration but the previous aliases and params are also re-registered, but the
$appsthen won't have the other application instances any more -> 💥