Make the app code checker a NOOP by ChristophWurst · Pull Request #25577 · nextcloud/server

ChristophWurst · 2021-02-11T10:34:52Z

For 21 we decided to drop this outdated checker and it was even documented: nextcloud/documentation#5505

so let's actually remove the functionality and "error out" every time it's called to make people aware. With Nextcloud 23 we can then fully drop it.

Signed-off-by: Christoph Wurst <[email protected]>

rullzer

🧹

faily-bot · 2021-02-12T09:35:40Z

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 2182: failure

integration-ldap-openldap-features

failure block could not be found - most likely this run got canceled

Show full log

+ bash tests/drone-run-integration-tests.sh || exit 0
=========================
= List of changed files =
=========================
core/Command/App/CheckCode.php
lib/composer/composer/autoload_classmap.php
lib/composer/composer/autoload_static.php
lib/private/App/CodeChecker/AbstractCheck.php
lib/private/App/CodeChecker/CodeChecker.php
lib/private/App/CodeChecker/DatabaseSchemaChecker.php
lib/private/App/CodeChecker/DeprecationCheck.php
lib/private/App/CodeChecker/EmptyCheck.php
lib/private/App/CodeChecker/ICheck.php
lib/private/App/CodeChecker/InfoChecker.php
lib/private/App/CodeChecker/LanguageParseChecker.php
lib/private/App/CodeChecker/MigrationSchemaChecker.php
lib/private/App/CodeChecker/NodeVisitor.php
lib/private/App/CodeChecker/PrivateCheck.php
lib/private/App/CodeChecker/StrongComparisonCheck.php
tests/lib/App/CodeChecker/CodeCheckerTest.php
tests/lib/App/CodeChecker/DeprecationCheckTest.php
tests/lib/App/CodeChecker/InfoCheckerTest.php
tests/lib/App/CodeChecker/Mock/TestList.php
tests/lib/App/CodeChecker/NodeVisitorTest.php
tests/lib/App/CodeChecker/StrongComparisonCheckTest.php
=========================
PHP files are modified
+ ./occ maintenance:install --admin-pass=admin --data-dir=/dev/shm/nc_int
Nextcloud was successfully installed
+ ./occ config:system:set redis host --value=cache
System config value redis => host set to string cache
+ ./occ config:system:set redis port --value=6379 --type=integer
System config value redis => port set to integer 6379
+ ./occ config:system:set redis timeout --value=0 --type=integer
System config value redis => timeout set to integer 0
+ ./occ config:system:set --type string --value "\OC\Memcache\Redis" memcache.local
System config value memcache.local set to string \OC\Memcache\Redis
+ ./occ config:system:set --type string --value "\OC\Memcache\Redis" memcache.distributed
PHP Warning:  Redis::connect(): php_network_getaddresses: getaddrinfo failed: Name or service not known in /drone/src/lib/private/RedisFactory.php on line 92
An unhandled exception has been thrown:
RedisException: Redis server went away in /drone/src/lib/private/Memcache/Redis.php:55
Stack trace:
#0 /drone/src/lib/private/Memcache/Redis.php(55): Redis->get('5abd12e093df7e4...')
#1 /drone/src/lib/private/App/InfoParser.php(60): OC\Memcache\Redis->get('/drone/src/apps...')
#2 /drone/src/lib/private/App/AppManager.php(511): OC\App\InfoParser->parse('/drone/src/apps...')
#3 /drone/src/lib/private/legacy/OC_App.php(589): OC\App\AppManager->getAppInfo('files', false, NULL)
#4 /drone/src/lib/private/AppFramework/App.php(70): OC_App::getAppInfo('files')
#5 /drone/src/lib/private/legacy/OC_App.php(270): OC\AppFramework\App::buildAppNamespace('files')
#6 /drone/src/lib/private/AppFramework/Bootstrap/Coordinator.php(108): OC_App::registerAutoloading('files', '/drone/src/apps...')
#7 /drone/src/lib/private/AppFramework/Bootstrap/Coordinator.php(82): OC\AppFramework\Bootstrap\Coordinator->registerApps(Array)
#8 /drone/src/lib/base.php(634): OC\AppFramework\Bootstrap\Coordinator->runInitialRegistration()
#9 /drone/src/lib/base.php(1076): OC::init()
#10 /drone/src/console.php(49): require_once('/drone/src/lib/...')
#11 /drone/src/occ(11): require_once('/drone/src/cons...')

integration-ldap-openldap-uid-features

failure block could not be found - most likely this run got canceled

Show full log

+ bash tests/drone-run-integration-tests.sh || exit 0
=========================
= List of changed files =
=========================
core/Command/App/CheckCode.php
lib/composer/composer/autoload_classmap.php
lib/composer/composer/autoload_static.php
lib/private/App/CodeChecker/AbstractCheck.php
lib/private/App/CodeChecker/CodeChecker.php
lib/private/App/CodeChecker/DatabaseSchemaChecker.php
lib/private/App/CodeChecker/DeprecationCheck.php
lib/private/App/CodeChecker/EmptyCheck.php
lib/private/App/CodeChecker/ICheck.php
lib/private/App/CodeChecker/InfoChecker.php
lib/private/App/CodeChecker/LanguageParseChecker.php
lib/private/App/CodeChecker/MigrationSchemaChecker.php
lib/private/App/CodeChecker/NodeVisitor.php
lib/private/App/CodeChecker/PrivateCheck.php
lib/private/App/CodeChecker/StrongComparisonCheck.php
tests/lib/App/CodeChecker/CodeCheckerTest.php
tests/lib/App/CodeChecker/DeprecationCheckTest.php
tests/lib/App/CodeChecker/InfoCheckerTest.php
tests/lib/App/CodeChecker/Mock/TestList.php
tests/lib/App/CodeChecker/NodeVisitorTest.php
tests/lib/App/CodeChecker/StrongComparisonCheckTest.php
=========================
PHP files are modified
+ ./occ maintenance:install --admin-pass=admin --data-dir=/dev/shm/nc_int
Nextcloud was successfully installed
+ ./occ config:system:set redis host --value=cache
System config value redis => host set to string cache
+ ./occ config:system:set redis port --value=6379 --type=integer
System config value redis => port set to integer 6379
+ ./occ config:system:set redis timeout --value=0 --type=integer
System config value redis => timeout set to integer 0
+ ./occ config:system:set --type string --value "\OC\Memcache\Redis" memcache.local
System config value memcache.local set to string \OC\Memcache\Redis
+ ./occ config:system:set --type string --value "\OC\Memcache\Redis" memcache.distributed
PHP Warning:  Redis::connect(): php_network_getaddresses: getaddrinfo failed: Name or service not known in /drone/src/lib/private/RedisFactory.php on line 92
An unhandled exception has been thrown:
RedisException: Redis server went away in /drone/src/lib/private/Memcache/Redis.php:55
Stack trace:
#0 /drone/src/lib/private/Memcache/Redis.php(55): Redis->get('384874226c5777e...')
#1 /drone/src/lib/private/App/InfoParser.php(60): OC\Memcache\Redis->get('/drone/src/apps...')
#2 /drone/src/lib/private/App/AppManager.php(511): OC\App\InfoParser->parse('/drone/src/apps...')
#3 /drone/src/lib/private/legacy/OC_App.php(589): OC\App\AppManager->getAppInfo('files', false, NULL)
#4 /drone/src/lib/private/AppFramework/App.php(70): OC_App::getAppInfo('files')
#5 /drone/src/lib/private/legacy/OC_App.php(270): OC\AppFramework\App::buildAppNamespace('files')
#6 /drone/src/lib/private/AppFramework/Bootstrap/Coordinator.php(108): OC_App::registerAutoloading('files', '/drone/src/apps...')
#7 /drone/src/lib/private/AppFramework/Bootstrap/Coordinator.php(82): OC\AppFramework\Bootstrap\Coordinator->registerApps(Array)
#8 /drone/src/lib/base.php(634): OC\AppFramework\Bootstrap\Coordinator->runInitialRegistration()
#9 /drone/src/lib/base.php(1076): OC::init()
#10 /drone/src/console.php(49): require_once('/drone/src/lib/...')
#11 /drone/src/occ(11): require_once('/drone/src/cons...')
#12 {main}```
</details>


#### integration-ldap-openldap-numerical-id-features
 * failure block could not be found - most likely this run got canceled
<details><summary>Show full log</summary>

bash tests/drone-run-integration-tests.sh || exit 0
=========================
= List of changed files =
=========================
core/Command/App/CheckCode.php
lib/composer/composer/autoload_classmap.php
lib/composer/composer/autoload_static.php
lib/private/App/CodeChecker/AbstractCheck.php
lib/private/App/CodeChecker/CodeChecker.php
lib/private/App/CodeChecker/DatabaseSchemaChecker.php
lib/private/App/CodeChecker/DeprecationCheck.php
lib/private/App/CodeChecker/EmptyCheck.php
lib/private/App/CodeChecker/ICheck.php
lib/private/App/CodeChecker/InfoChecker.php
lib/private/App/CodeChecker/LanguageParseChecker.php
lib/private/App/CodeChecker/MigrationSchemaChecker.php
lib/private/App/CodeChecker/NodeVisitor.php
lib/private/App/CodeChecker/PrivateCheck.php
lib/private/App/CodeChecker/StrongComparisonCheck.php
tests/lib/App/CodeChecker/CodeCheckerTest.php
tests/lib/App/CodeChecker/DeprecationCheckTest.php
tests/lib/App/CodeChecker/InfoCheckerTest.php
tests/lib/App/CodeChecker/Mock/TestList.php
tests/lib/App/CodeChecker/NodeVisitorTest.php
tests/lib/App/CodeChecker/StrongComparisonCheckTest.php
=========================
PHP files are modified
./occ maintenance:install --admin-pass=admin --data-dir=/dev/shm/nc_int
Nextcloud was successfully installed
./occ config:system:set redis host --value=cache
System config value redis => host set to string cache
./occ config:system:set redis port --value=6379 --type=integer
System config value redis => port set to integer 6379
./occ config:system:set redis timeout --value=0 --type=integer
System config value redis => timeout set to integer 0
./occ config:system:set --type string --value "\OC\Memcache\Redis" memcache.local
System config value memcache.local set to string \OC\Memcache\Redis
./occ config:system:set --type string --value "\OC\Memcache\Redis" memcache.distributed
PHP Warning: Redis::connect(): php_network_getaddresses: getaddrinfo failed: Name or service not known in /drone/src/lib/private/RedisFactory.php on line 92
An unhandled exception has been thrown:
RedisException: Redis server went away in /drone/src/lib/private/Memcache/Redis.php:55
Stack trace:
#0 /drone/src/lib/private/Memcache/Redis.php(55): Redis->get('aa36c32fc8b5d0d...')
Name the repository "server" #1 /drone/src/lib/private/App/InfoParser.php(60): OC\Memcache\Redis->get('/drone/src/apps...')
Some more links, structure adjustment and CoC #2 /drone/src/lib/private/App/AppManager.php(511): OC\App\InfoParser->parse('/drone/src/apps...')
Use shields for IRC links #3 /drone/src/lib/private/legacy/OC_App.php(589): OC\App\AppManager->getAppInfo('files', false, NULL)
File requests / Files Drop for the community #4 /drone/src/lib/private/AppFramework/App.php(70): OC_App::getAppInfo('files')
File view: Double click and right click #5 /drone/src/lib/private/legacy/OC_App.php(270): OC\AppFramework\App::buildAppNamespace('files')
Add a thumbnail/grid view to the Files app #6 /drone/src/lib/private/AppFramework/Bootstrap/Coordinator.php(108): OC_App::registerAutoloading('files', '/drone/src/apps...')
Update readme #7 /drone/src/lib/private/AppFramework/Bootstrap/Coordinator.php(82): OC\AppFramework\Bootstrap\Coordinator->registerApps(Array)
Change ownCloud to Nextcloud in the support section #8 /drone/src/lib/base.php(634): OC\AppFramework\Bootstrap\Coordinator->runInitialRegistration()
Remove "Help" link from personal sidebar #9 /drone/src/lib/base.php(1076): OC::init()
[stable9] Remove "Help" link from personal sidebar #10 /drone/src/console.php(49): require_once('/drone/src/lib/...')
update license script: no more CLA and switch to AGPLv3 or later #11 /drone/src/occ(11): require_once('/drone/src/cons...')

</details>


#### acceptance-users
 * tests/acceptance/features/users.feature:47
<details><summary>Show full log</summary>

Scenario: users navigation without disabled users # /drone/src/tests/acceptance/features/users.feature:47
Given I act as Jane # ActorContext::iActAs()
And I am logged in as the admin # LoginPageContext::iAmLoggedInAsTheAdmin()
And I open the User settings # SettingsMenuContext::iOpenTheUserSettings()
And I open the "Disabled users" section # AppNavigationContext::iOpenTheSection()
And I see that the list of users contains the user disabledUser # UsersSettingsContext::iSeeThatTheListOfUsersContainsTheUser()
And I open the actions menu for the user disabledUser # UsersSettingsContext::iOpenTheActionsMenuOf()
Row for user disabledUser in Users Settings could not be found
Actions menu for user disabledUser in Users Settings could not be found (NoSuchElementException)
And I see that the "Enable user" action in the disabledUser actions menu is shown # UsersSettingsContext::iSeeTheAction()
When I click the "Enable user" action in the disabledUser actions menu # UsersSettingsContext::iClickTheAction()
Then I see that the section "Disabled users" is not shown # AppNavigationContext::iSeeThatTheSectionIsNotShown()
When I open the User settings # SettingsMenuContext::iOpenTheUserSettings()
Then I see that the section "Disabled users" is not shown # AppNavigationContext::iSeeThatTheSectionIsNotShown()

</details>

nickvergessen · 2021-02-12T12:40:45Z

lib/private/App/CodeChecker/LanguageParseChecker.php

-
-namespace OC\App\CodeChecker;
-
-class LanguageParseChecker {


I guess this thing here should be checked in some other way. But it's the only useful thing.

Was there ever a time where this didn't pass?

yes, that's why it was written in first place. It happens when non-asci translators add half-utf8 chars which are not valid utf4 chars.

Okay, but that we can do in a simple php script and a github action

ChristophWurst added 3. to review Waiting for reviews technical debt labels Feb 11, 2021

ChristophWurst added this to the Nextcloud 22 milestone Feb 11, 2021

ChristophWurst requested review from nickvergessen and rullzer February 11, 2021 10:34

ChristophWurst self-assigned this Feb 11, 2021

Make the app code checker a NOOP

e618ea8

Signed-off-by: Christoph Wurst <[email protected]>

ChristophWurst force-pushed the enhancement/app-code-checker-noop branch from 4cdb633 to e618ea8 Compare February 11, 2021 10:46

rullzer approved these changes Feb 11, 2021

View reviewed changes

nickvergessen reviewed Feb 12, 2021

View reviewed changes

nickvergessen approved these changes Feb 12, 2021

View reviewed changes

rullzer merged commit 24d4c3e into master Feb 13, 2021

rullzer deleted the enhancement/app-code-checker-noop branch February 13, 2021 14:51

This was referenced May 31, 2023

chore: Drop app code checker test data #38550

Merged

Remove deprecated occ app:check-code command #32210

Merged

joshtrichards mentioned this pull request Mar 30, 2024

NC14.0.1 & previewgenerator 1.1.0: "App is not compliant" nextcloud/previewgenerator#132

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Comments

Make the app code checker a NOOP#25577

Make the app code checker a NOOP#25577
rullzer merged 1 commit intomasterfrom
enhancement/app-code-checker-noop

ChristophWurst commented Feb 11, 2021

Uh oh!

rullzer left a comment

Uh oh!

faily-bot bot commented Feb 12, 2021

Uh oh!

nickvergessen Feb 12, 2021

Uh oh!

ChristophWurst Feb 12, 2021

Uh oh!

nickvergessen Feb 12, 2021

Uh oh!

ChristophWurst Feb 12, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants


		namespace OC\App\CodeChecker;

		class LanguageParseChecker {

Uh oh!

Comments

Conversation

ChristophWurst commented Feb 11, 2021

Uh oh!

rullzer left a comment

Choose a reason for hiding this comment

Uh oh!

faily-bot bot commented Feb 12, 2021

Status of 2182: failure

integration-ldap-openldap-features

integration-ldap-openldap-uid-features

Uh oh!

nickvergessen Feb 12, 2021

Choose a reason for hiding this comment

Uh oh!

ChristophWurst Feb 12, 2021

Choose a reason for hiding this comment

Uh oh!

nickvergessen Feb 12, 2021

Choose a reason for hiding this comment

Uh oh!

ChristophWurst Feb 12, 2021

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants