Allow admin to decide whether to use multipart or not.#23781
Closed
mseravalli wants to merge 1 commit intonextcloud:masterfrom
mseravalli:master
Closed
Allow admin to decide whether to use multipart or not.#23781mseravalli wants to merge 1 commit intonextcloud:masterfrom mseravalli:master
mseravalli wants to merge 1 commit intonextcloud:masterfrom
mseravalli:master
Conversation
Some of the S3 implementations, e.g. GCS, does not implement the MultipartUploadere the same way that ASW S3 does and it is not 100% compatible. To overcome this we allow the admin to give the possibility to use a simple uploader. The uploader for the empty type should not be an exception.
Contributor
|
It's not possible to use the ObjectUploader: #21958 |
skjnldsv
added
the
0. Needs triage
icewind1991
requested changes
Nov 2, 2020
| } | ||
|
|
||
| // This is an empty file so just touch it then | ||
| if ($count === 0 && feof($countStream)) { |
Member
There was a problem hiding this comment.
$count will always be 0 here, since the callback that does the counting, only gets called during the actual upload, and thus $count will only be the "proper" value once the upload is completed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some of the S3 implementations, e.g. GCS, does not implement the
MultipartUploadere the same way that ASW S3 does and it is not 100%
compatible. To overcome this we allow the admin to give the possibility
to use a simple uploader.
The uploader for an empty file should not be an exception.