Conversation
Signed-off-by: Jan-Christoph Borchardt <[email protected]>
jancborchardt
added
3. to review
|
@jancborchardt, thanks for your PR! By analyzing the history of the files in this pull request, we identified @LukasReschke, @blizzz and @PVince81 to be potential reviewers. |
|
Agree! I think the reason I opted to retain the checkboxes was due to the fact users may not want to enable editing of folder contents by default. As it stands currently when you share there's a read-only link, which you can optionally grant permissions on. Perhaps this radio would have to have three options, with the read-only option being chosen by default. |
This makes much sense |
|
Right, it needs to be a 3-option-radio button. Do we want to merge this wording fix in then? The radio button enhancement has to wait until Nextcloud 12 :) |
|
Please merge. Can we expect 12 by.. say.. Christmas? ;) |
|
LGTM |
5 participants
This is the first half of what @jasonbayton proposed in #2207
The wording improvement is already good on its own. We could additionally improve it by showing both options, making them radio buttons, with »Allow upload and editing« being the default. This is probably something for Nextcloud 12 though since feature freeze? cc @nextcloud/javascript
(@jasonbayton I think the greying out would confuse people as to the clickability of the second option, so a radio button is better here. :)