Deprecate ILogger in favor of the PSR-3 logger#21875
Merged
MorrisJobke merged 2 commits intomasterfrom Jul 20, 2020
Merged
Conversation
The logger service was always intended to follow the PSR-3 interface. It's time to embrace this and switch over to the "official" API, hence this custom interface can be slowly phased out. With Nextcloud 20 the logger also got support for * App id filled out automatically * Exceptions handling (as replacement for logException) Signed-off-by: Christoph Wurst <[email protected]>
ChristophWurst
added
3. to review
ChristophWurst
requested review from
ArtificialOwl,
blizzz,
julien-nc,
juliusknorr,
marcoambrosini and
rullzer
ChristophWurst
changed the title
Member
Author
|
As a demonstration of the changes I've migrated one small app. |
Signed-off-by: Christoph Wurst <[email protected]>
ChristophWurst
force-pushed
the
techdebt/deprecate-ilogger
branch
from
f0433dd to
b3b856c
Compare
rullzer
approved these changes
Jul 16, 2020
MorrisJobke
approved these changes
Jul 20, 2020
Member
Author
|
Documented in nextcloud/documentation#5160 |
ChristophWurst
removed
the
pending documentation
R0Wi
added a commit
to R0Wi-DEV/workflow_ocr
that referenced
this pull request
Oct 9, 2020
bahnwaerter
pushed a commit
to R0Wi-DEV/workflow_ocr
that referenced
this pull request
Oct 10, 2020
* NC20 IBootStrap, LoggerInterface, * Cover RegisterFlowOperationsListener * Add tests * Use PSR-3 ContainerInterface * Include autoload.php inside of Application * Lint fix * Exception serialization (see nextcloud/server#21875)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The logger service was always intended to follow the PSR-3 interface.
It's time to embrace this and switch over to the "official" API,
hence this custom interface can be slowly phased out.
With Nextcloud 20 the logger also got support for
So there are no more excuses not to use this 😉