Conversation
rullzer
force-pushed
the
td/remove/irouter_cleanup
branch
from
2f82eab to
e5ee7c6
Compare
MorrisJobke
reviewed
Jul 6, 2020
| * @since 8.0.0 | ||
| * @deprecated 9.0.0 | ||
| */ | ||
| public function getCurrentCollection(); |
Member
There was a problem hiding this comment.
This is used in
As the $this->router is type hinted as IRouter it needs to be changed to Router first.
Member
Author
There was a problem hiding this comment.
Did some more cleanup should be good to go now
MorrisJobke
added
2. developing
rullzer
force-pushed
the
td/remove/irouter_cleanup
branch
from
e5ee7c6 to
4a09a97
Compare
rullzer
added
pending documentation
juliusknorr
force-pushed
the
td/remove/irouter_cleanup
branch
from
4a09a97 to
2188f17
Compare
Member
|
Rebased and fixed the php cs issue |
rullzer
force-pushed
the
td/remove/irouter_cleanup
branch
from
62359e7 to
983c1ee
Compare
This is not the end. IRouter needs to burn. But it is a start. 🎵 we didn't start the fire 🎵 Signed-off-by: Roeland Jago Douma <[email protected]>
rullzer
force-pushed
the
td/remove/irouter_cleanup
branch
from
983c1ee to
72a9c35
Compare
Member
|
Added to #23210 |
MorrisJobke
removed
the
pending documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is not the end. IRouter needs to burn.
But it is a start.
🎵 we didn't start the fire 🎵
Signed-off-by: Roeland Jago Douma [email protected]