Fix checkboxes when theming color is enabled#2157
Merged
nickvergessen merged 2 commits intomasterfrom Nov 16, 2016
Merged
Conversation
juliusknorr
added
3. to review
|
@juliushaertl, thanks for your PR! By analyzing the history of the files in this pull request, we identified @skjnldsv, @jancborchardt and @LukasReschke to be potential reviewers. |
Signed-off-by: Julius Haertl <[email protected]>
juliusknorr
force-pushed
the
fix-checkboxes
branch
from
753d36a to
beeb819
Compare
Member
|
Works, as soon as the css file is rewritten (by changing the color) 👍 |
Member
|
What about the previous issue with the select in dropdown from the users management? Is it still fixed? |
Member
Author
|
@skjnldsv It is. 😉 |
Member
|
👍 🎉 |
67 tasks
Member
|
Awesome work @juliushaertl 🤘 :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #2089
Before
After
Checkboxes in user management also still work (#1782) - These should also be tested since the original fix #1971 has been reverted here.
Please review @nextcloud/designers @nickvergessen