Skip to content

Comments

Provide dav setting for user's default calendar#19852

Merged
skjnldsv merged 2 commits intomasterfrom
dav/provide-dav-setting-for-default-calendar
Apr 13, 2020
Merged

Provide dav setting for user's default calendar#19852
skjnldsv merged 2 commits intomasterfrom
dav/provide-dav-setting-for-default-calendar

Conversation

@tcitworld
Copy link
Member

@tcitworld tcitworld commented Mar 8, 2020 •
edited
Loading

And add tests to handle schedule-default-calendar-URL

Part 1 for #19826

@tcitworld tcitworld added 3. to review Waiting for reviews feature: dav labels Mar 8, 2020
@tcitworld tcitworld added this to the Nextcloud 19 milestone Mar 8, 2020
@tcitworld tcitworld requested review from georgehrke and rullzer March 8, 2020 16:34
@tcitworld tcitworld force-pushed the dav/provide-dav-setting-for-default-calendar branch from 6867a83 to 229fb7a Compare March 8, 2020 17:23
@georgehrke
Copy link
Member

georgehrke commented Mar 9, 2020

Just double checked to make sure:
The dav property is a protected one: https://github.com/nextcloud/3rdparty/blob/master/sabre/dav/lib/CalDAV/Schedule/Plugin.php#L129

@georgehrke
Copy link
Member

georgehrke commented Mar 10, 2020

@tcitworld What is your concept for the endpoint for setting this?
Some DAV method or just a Controller endpoint?

@tcitworld
Copy link
Member Author

tcitworld commented Mar 10, 2020

Since the property was read-only in Sabre I only thought of it at first as a Controller endpoint. We could indeed do that through a DAV method, but is it worth it anyway? Does macOS/iOS Calendar handle this?

@georgehrke
Copy link
Member

georgehrke commented Mar 10, 2020

No, the only two interesting things you can configure via DAV in macOS are default alarms for timed events and allday events:

<A:propertyupdate xmlns:A="DAV:">
	<A:set>
		<A:prop>
			<B:default-alarm-vevent-datetime xmlns:B="urn:ietf:params:xml:ns:caldav">
				<![CDATA[BEGIN:VALARM
				X-WR-ALARMUID:7254E71A-A1F6-41F5-A006-1B435D9B78E3
				UID:7254E71A-A1F6-41F5-A006-1B435D9B78E3
				TRIGGER:-PT30M
				ATTACH;VALUE=URI:Chord
				ACTION:AUDIO
				END:VALARM
				]]>
			</B:default-alarm-vevent-datetime>
		</A:prop>
	</A:set>
</A:propertyupdate>

<A:propertyupdate xmlns:A="DAV:">
	<A:set>
		<A:prop>
			<B:default-alarm-vevent-date xmlns:B="urn:ietf:params:xml:ns:caldav">
				<![CDATA[BEGIN:VALARM
				X-WR-ALARMUID:659B19ED-7E2B-427A-9ABA-973206876796
				UID:659B19ED-7E2B-427A-9ABA-973206876796
				TRIGGER:-P1DT15H
				ATTACH;VALUE=URI:Chord
				ACTION:AUDIO
				END:VALARM
				]]>
			</B:default-alarm-vevent-date>
		</A:prop>
	</A:set>
</A:propertyupdate>

Changing the default calendar does not result in any CalDAV requests.

nickvergessen
nickvergessen reviewed Mar 13, 2020
View reviewed changes
nickvergessen
nickvergessen approved these changes Mar 13, 2020
View reviewed changes
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general

tcitworld
tcitworld commented Mar 13, 2020
View reviewed changes
@tcitworld tcitworld force-pushed the dav/provide-dav-setting-for-default-calendar branch from 229fb7a to 0fb2955 Compare March 13, 2020 10:58
@georgehrke georgehrke requested review from julien-nc and juliusknorr and removed request for julien-nc March 17, 2020 14:33
@rullzer rullzer mentioned this pull request Apr 4, 2020
Merged
80 tasks
@tcitworld tcitworld force-pushed the dav/provide-dav-setting-for-default-calendar branch from 0fb2955 to e91636d Compare April 5, 2020 18:59
@rullzer rullzer mentioned this pull request Apr 9, 2020
Merged
59 tasks
@skjnldsv
Copy link
Member

skjnldsv commented Apr 11, 2020

Conflicts

@skjnldsv skjnldsv added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Apr 11, 2020
@tcitworld
Provide dav setting for user's default calendar
ebdf66b 
And add tests to handle schedule-default-calendar-URL

Signed-off-by: Thomas Citharel <[email protected]>
@tcitworld
Only delete the default calendar setting when the default calendar
0408c37 
itself is deleted

Signed-off-by: Thomas Citharel <[email protected]>
@tcitworld tcitworld force-pushed the dav/provide-dav-setting-for-default-calendar branch from e91636d to 0408c37 Compare April 13, 2020 13:07
@tcitworld
Copy link
Member Author

tcitworld commented Apr 13, 2020

Rebased and php-cs-fixed :)

@tcitworld tcitworld added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Apr 13, 2020
@skjnldsv skjnldsv merged commit 3ea9dd8 into master Apr 13, 2020
@skjnldsv skjnldsv deleted the dav/provide-dav-setting-for-default-calendar branch April 13, 2020 15:00
This was referenced Jun 25, 2021
Closed
Closed
@tcitworld tcitworld mentioned this pull request Jun 21, 2022
Closed
@tcitworld tcitworld mentioned this pull request Sep 2, 2022
Closed
@st3iny st3iny mentioned this pull request Jan 3, 2025
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@georgehrke georgehrke georgehrke approved these changes

@rullzer rullzer Awaiting requested review from rullzer

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

Assignees

No one assigned

Labels

3. to review Waiting for reviews feature: dav

Projects

None yet

Milestone

Nextcloud 19

Development

Successfully merging this pull request may close these issues.

4 participants

@tcitworld @georgehrke @skjnldsv @nickvergessen