Conversation
ChristophWurst
added
enhancement
3. to review
Signed-off-by: Christoph Wurst <[email protected]>
ChristophWurst
force-pushed
the
enhancement/address-book-plugins
branch
from
9c302de to
ec245d5
Compare
juliusknorr
left a comment
juliusknorr
left a comment
There was a problem hiding this comment.
Looks good otherwise and seems to do the trick with the parts already available in #19075
There was a problem hiding this comment.
UserAddressbooks should check for reserved names when creating a new collection.
Similar to here: https://github.com/nextcloud/server/blob/master/apps/dav/lib/CalDAV/CalendarHome.php#L76L84
Signed-off-by: Christoph Wurst <[email protected]>
|
Thanks @georgehrke. Added the check :) |
rullzer
left a comment
rullzer
left a comment
There was a problem hiding this comment.
Didn't do extensive testing. But code looks sane
|
@georgehrke ok to merge this? :) |
|
@ChristophWurst the extension of info.xml has to be defined in https://github.com/nextcloud/appstore/blob/master/nextcloudappstore/api/v1/release/info.xsd |
|
👍 I'll also add it for #19196 while at it |
For #19795 For #19196 Ref nextcloud/appstore#673 Signed-off-by: Christoph Wurst <[email protected]>
For #19795 For #19196 Ref nextcloud/appstore#673 Signed-off-by: Christoph Wurst <[email protected]>
5 participants
Somehow Github refused to reopen #19680, thus a new PR.
Same same as #19196 but different.
Tested with #19075