Conversation
|
@MorrisJobke, thanks for your PR! By analyzing the history of the files in this pull request, we identified @LukasReschke, @DeepDiver1975 and @owncloud-bot to be potential reviewers. |
rullzer
reviewed
Oct 25, 2016
console.php
Outdated
| // Show warning if a PHP version below 5.6.0 is used, this has to happen here | ||
| // because base.php will already use 5.6 syntax. | ||
| if (version_compare(PHP_VERSION, '5.6.0') === -1) { | ||
| echo 'This version of Nextcloud requires at least PHP 5.4.0'.PHP_EOL; |
Signed-off-by: Morris Jobke <[email protected]>
MorrisJobke
force-pushed
the
fix-php-version-check
branch
from
88658e3 to
6df9090
Compare
Member
|
👍 |
nickvergessen
added
4. to release
Current coverage is 57.28% (diff: 0.00%)@@ master #1898 diff @@
==========================================
Files 1075 1075
Lines 61319 61319
Methods 6851 6851
Messages 0 0
Branches 0 0
==========================================
- Hits 35125 35124 -1
- Misses 26194 26195 +1
Partials 0 0
|
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @LukasReschke @rullzer @nickvergessen