Remove whitespace above file list ref #17891#17989
Conversation
Noodlesalat
force-pushed
the
fix-padding-top-filelist
branch
from
49f921f to
0b2e32f
Compare
This reverts nextcloud#16366 and fixes nextcloud#17891 Signed-off-by: Fabian Dreßler <[email protected]>
Noodlesalat
force-pushed
the
fix-padding-top-filelist
branch
from
0b2e32f to
8261e74
Compare
|
@Noodlesalat nice! Does this still fix the original issue which was intended to be fixed by the reverted pull request? @Gatak could you review this pull request as it fixes the issue you reported at #17891 :) |
|
I wasn't able to reproduce the mentioned original issue with my development instance. :) |
|
@GretaD can you check, since it reverts a pull request of yours? |
sure, its on my "this week" list. |
There was a problem hiding this comment.
It works like it should, the first row its shown correctly and the space is smaller. Very good @Noodlesalat :)
gary-kim
added
4. to release
gary-kim
left a comment
gary-kim
left a comment
There was a problem hiding this comment.
This is the first change made to the AUTHORS file in 2 years. Is that made by a script or added by authors?
Good question, also regarding the copyright header – which would basically have a lot more people but in practice we don’t do that with every pull request (especially not 2 line ones like this). cc @rullzer @schiessle can you provide input? |
|
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
7 participants
This reverts #16366 and fixes #17891
Result:
Signed-off-by: Fabian Dreßler [email protected]