Allow registering header/footer sections in the file lists#17482
Merged
Allow registering header/footer sections in the file lists#17482
Conversation
1 task
juliusknorr
force-pushed
the
feature/noid/rich-workspace
branch
from
c17bdc6 to
2226720
Compare
juliusknorr
added
3. to review
kesselb
reviewed
Oct 16, 2019
danxuliu
requested changes
Oct 17, 2019
ChristophWurst
approved these changes
Oct 22, 2019
danxuliu
approved these changes
Oct 22, 2019
Member
danxuliu
left a comment
danxuliu
left a comment
There was a problem hiding this comment.
Tested and works 👍
Note that the footer is a bit separated from the table due to the summary height. I guess that it would be good to add that space only if there are no footers, although we can worry about that later too ;-)
Member
|
Fixup and we get it in @juliushaertl ! |
Closed
Signed-off-by: Julius Härtl <[email protected]>
juliusknorr
force-pushed
the
feature/noid/rich-workspace
branch
from
693f0c6 to
975c198
Compare
juliusknorr
added
4. to release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows filelist plugins to register header/footer sections