Skip to content

Comments

Deprecate the global DOMPurify#17130

Merged
rullzer merged 1 commit intomasterfrom
refactor/deprecate-global-dompurify
Sep 14, 2019
Merged

Deprecate the global DOMPurify#17130
rullzer merged 1 commit intomasterfrom
refactor/deprecate-global-dompurify

Conversation

@ChristophWurst
Copy link
Member

Found at #17123.

We don't really use it globally anymore, so no reason to keep it exported.

$ rg dompurify -M 300 -t js
core/src/globals.js
78:import DOMPurify from 'dompurify'

settings/js/vue-5.js
1:[Omitted long line with 1 matches]

core/js/dist/main.js
338:[Omitted long line with 1 matches]

settings/src/components/appDetails.vue
103:import dompurify from 'dompurify'
193:			return dompurify.sanitize(

@ChristophWurst ChristophWurst force-pushed the refactor/deprecate-global-dompurify branch from 29afff5 to e912a77 Compare September 13, 2019 13:55
@blizzz
Copy link
Member

blizzz commented Sep 14, 2019

conflicts

@rullzer
Copy link
Member

rullzer commented Sep 14, 2019

/compile amend /

Signed-off-by: Christoph Wurst <[email protected]>
@rullzer rullzer force-pushed the refactor/deprecate-global-dompurify branch from e912a77 to db7cd7d Compare September 14, 2019 11:29
@rullzer rullzer merged commit 4cae5ae into master Sep 14, 2019
@rullzer rullzer deleted the refactor/deprecate-global-dompurify branch September 14, 2019 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants