Warn user before closing when uploading a file on a upload only link#16984
Merged
Warn user before closing when uploading a file on a upload only link#16984
Conversation
Signed-off-by: Julius Härtl <[email protected]>
juliusknorr
requested review from
ChristophWurst,
danxuliu,
rullzer and
skjnldsv
ChristophWurst
approved these changes
Sep 3, 2019
| e.preventDefault(); | ||
| $('#public-upload #emptycontent input').focus().trigger('click'); | ||
| }); | ||
| window.onbeforeunload = function() { |
Member
There was a problem hiding this comment.
Typically, it is better to use window.addEventListener() and the beforeunload event, instead of onbeforeunload.
Member
There was a problem hiding this comment.
Ah yes! Especially since we remove inline scripts with csp :)
Member
Author
There was a problem hiding this comment.
I don't have a strong oppinion, this code is mainly a copy of what we use here:
server/apps/files/js/file-upload.js
Line 1291 in 07c3665
So I'd say lets get it in and we can cleanup if we might refactor at some point, as I don't see any downside of that code for now
ChristophWurst
approved these changes
Sep 6, 2019
Member
|
Backport to 17? |
Member
Author
|
Yes, I'd say so. |
Member
Author
|
/backport to stable17 |
|
backport to stable17 in #17034 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure the browser shows a warning that a upload is still ongoing when uploading files though a drop only link.