Add repair step and revert "Open updater" button#1499
Merged
LukasReschke merged 5 commits intomasterfrom Sep 26, 2016
Merged
Conversation
This reverts commit 202ae42. Signed-off-by: Morris Jobke <[email protected]>
Signed-off-by: Morris Jobke <[email protected]>
MorrisJobke
added
enhancement
3. to review
|
@MorrisJobke, thanks for your PR! By analyzing the annotation information on this pull request, we identified @nickvergessen, @LukasReschke and @blizzz to be potential reviewers |
Member
|
nice 👍 As discussed! |
This was referenced Sep 23, 2016
MorrisJobke
force-pushed
the
updater
branch
2 times, most recently
from
479cb77 to
9130d3a
Compare
Member
Author
|
needed to rebase to fix the sign-off message in the commits ;) |
MorrisJobke
force-pushed
the
updater
branch
from
9130d3a to
0650e46
Compare
| 'updateLink' => 'https://docs.nextcloud.com/myUrl', | ||
| 'downloadLink' => 'https://downloads.nextcloud.org/server', | ||
| 'updateVersion' => 'ownCloud 123', | ||
| 'updateLink' => 'https://owncloud.org/myUrl', |
Member
There was a problem hiding this comment.
Id not revert all in this, when possible
Member
Author
There was a problem hiding this comment.
True story. I will fix it.
Member
|
Looks good otherwise |
This reverts commit 27a3c68. Signed-off-by: Morris Jobke <[email protected]>
Signed-off-by: Morris Jobke <[email protected]>
Signed-off-by: Morris Jobke <[email protected]>
MorrisJobke
force-pushed
the
updater
branch
from
0650e46 to
afe40ac
Compare
Member
Author
|
I added the wrongly removed tests here. |
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
data/updater-INSTANCEID/.stepto a file named.step-previous-updateto not show all steps as done on the next updatecc @LukasReschke @nickvergessen @karlitschek
I will open the PRs for stable9 and stable10 soon