Conversation
|
I can confirm this fixed my S3 sync issue for NC 15.0.7. |
|
/backport to stable16 |
|
/backport to stable15 |
|
Just tested this PR against my Nextcloud 15.0.8 running in the docker. Upd: Whilst this PR makes Nextcloud work with S3 (minio) directories, I think it still needs to be polished a bit (see my next comment). |
|
For some reason, though, I am getting these tooltip messages when creating a subdirectory under any top-level directory, e.g. Despite of that tooltip message, the directory gets created fine. Upd: and the size for all directories is "Pending", files are ok (files do get their size there). |
|
My situation: local nextcloud+minio, all auto-configured to run isolated in a docker-compose. A short shell script configures everything at start-of-day. My test procedure is to do 'docker-compose down -v', then './first-run.sh', which brings everything back up. I then create a folder in nextcloud, for the minio external storage, and I can see that the folder does exist in the /data directory in minio(from the shell). I can not create a file, via nextcloud, I get a tooltip error. If I then create file by hand, using the shell, and initiate a occ files:scan, the folder disappears. I checked the filecache table in postgresql. If I delete the manually created file, do another scan, the folder comes back. I then placed the modified file from this PR, into my nextcloud. Now, the occ file:scan does see the folder, when a file has been manually created in /data in minio. However, I still can't create files(in nextcloud, I select "New File", and then type "AnyName.txt". I get a tooltip error upon creation. So, this PR still needs work to fix the full minio+nextcloud integration. |
|
Mind to create a new issue for your problem? Please include the error message and logs. |
0efdb1f to
d037ebb
Compare
d037ebb to
89a2845
Compare
|
@icewind1991 mind to have a look? |
|
Master is no 18 development. If this needs to go into 17 please follow the normal backport procedures after merging. |
|
/backport to stable17 |
|
when will this be backported to v16? |
Signed-off-by: Daniel Kesselberg <[email protected]>
Signed-off-by: Daniel Kesselberg <[email protected]>
Signed-off-by: Daniel Kesselberg <[email protected]>
Signed-off-by: Daniel Kesselberg <[email protected]>
Signed-off-by: Daniel Kesselberg <[email protected]>
Signed-off-by: Daniel Kesselberg <[email protected]>
89a2845 to
72d22a4
Compare
|
backport to stable16 in #17271 |
|
backport to stable15 in #17272 |
|
backport to stable17 in #17273 |
|
@kesselb I upgraded my snap to |
|
That is because it is in 17.0.1 only |
Fix #6954
Fix #9808
Test:
occ files:scan-> files are there (after this patch)Tried to add some test cases for this but i don't understand how the s3 testing works 😞