@juliushaertl like this? ^

@juliushaertl @ChristophWurst @skjnldsv can we have another review here?

may I add myself as author to the file header now? or what do you consider a "substantial change"?

may I add myself as author to the file header now? or what do you consider a "substantial change"?

You can always add yourself to the header. I'd even say you always should. But most of the time people forget :/

You can always add yourself to the header. I'd even say you always should. But most of the time people forget :/

good to know! I've done it now...

$responseComposer = [];

if ($shareIsFolder) {
	$responseComposer[] = new SimpleMenuAction('download', $this->l10n->t('Download all files'), 'icon-download-white', $shareTmpl['downloadURL'], 0);
	$responseComposer[] = new SimpleMenuAction('download', $this->l10n->t('Download all files'), 'icon-download', $shareTmpl['downloadURL'], 10, $shareTmpl['fileSize']);
} else {
	$responseComposer[] = new SimpleMenuAction('download', $this->l10n->t('Download'), 'icon-download-white', $shareTmpl['downloadURL'], 0);
	$responseComposer[] = new SimpleMenuAction('download', $this->l10n->t('Download'), 'icon-download', $shareTmpl['downloadURL'], 10, $shareTmpl['fileSize']);
}

$responseComposer[] = new LinkMenuAction($this->l10n->t('Direct link'), 'icon-public', $shareTmpl['previewURL']);
if ($this->federatedShareProvider->isOutgoingServer2serverShareEnabled()) {
	$responseComposer[] = new ExternalShareMenuAction($this->l10n->t('Add to your Nextcloud'), 'icon-external', $shareTmpl['owner'], $shareTmpl['displayName'], $shareTmpl['filename']);
}

I think it looks cleaner if you do it like above. Yes the download buttons looks similar but they are different. If you dont agree just ignore 🤣

@danielkesselberg thank you! I get your point; the variables are only assigned and use once, so not really necessary -- however I think it's easier to read the code with the variables... But if you want the code to be more compact I can change it :)

@danielkesselberg thank you! I get your point; the variables are only assigned and use once, so not really necessary -- however I think it's easier to read the code with the variables... But if you want the code to be more compact I can change it :)

Up to you ;-) If someone approves a pull request and suggests changes they are not mandatory (i think they are not mandatory but could be wrong 🤣)

what's wrong with drone here?

@violoncelloCH can you rebase? Drone will recreate itself :)

rebase done...

looks like there is always one randomly failing drone test... :/

They are unrelated - it was a codecov failure.