Remove deprecated functions from SecureRandom#12907
Merged
Conversation
rullzer
requested review from
ChristophWurst,
MorrisJobke,
icewind1991,
juliusknorr and
nickvergessen
MorrisJobke
reviewed
Dec 7, 2018
| * @since 8.0.0 | ||
| * @deprecated 9.0.0 Use \OC\Security\SecureRandom::generate directly or random_bytes() / random_int() | ||
| */ | ||
| public function getMediumStrengthGenerator(); |
Member
Author
There was a problem hiding this comment.
ChristophWurst
approved these changes
Dec 7, 2018
rullzer
added a commit
to nextcloud/guests
that referenced
this pull request
Dec 7, 2018
getMediumStrengthGenerator is deprecated and will be removed in NC16 nextcloud/server#12907
rullzer
added a commit
to rullzer/ownpad
that referenced
this pull request
Dec 7, 2018
getMediumStrengthGenerator is deprecated and will be removed in NC16 nextcloud/server#12907
This was referenced Dec 7, 2018
Member
Author
|
Added to #12915 |
MorrisJobke
approved these changes
Dec 7, 2018
Member
|
Unit tests make 💥 |
Signed-off-by: Roeland Jago Douma <[email protected]>
rullzer
force-pushed
the
td/securerandom/remove_deprecated_functions
branch
from
2dc53c2 to
372f3d2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Roeland Jago Douma [email protected]