Merged
Conversation
|
@rullzer, thanks for your PR! By analyzing the annotation information on this pull request, we identified @DeepDiver1975, @patelfenil and @Kondou-ger to be potential reviewers |
Member
|
When opening http://10.211.55.7/stable9/index.php/settings/personal I get |
Member
|
Well. Also in all other views 🙈 |
rullzer
force-pushed
the
cache_avatars
branch
2 times, most recently
from
aea6ab7 to
d07c5ba
Compare
Member
Author
|
Rabased to hard. |
* Set proper caching headers for avatars (15 minutes) * For our own avatar use some extra logic to invalidate when we update
Member
|
Tested and works 👍 |
Member
|
@LukasReschke @nickvergessen Mind to review? |
Member
|
Good stuff 👍 |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We finally start to cache avatars. Because there is absolutely no reason to hit the server for every avatar all the time. Since avatars are rarely updated anyway there is also no need to ask the server every time. If we combine this with #1121 the avatars create a lot less load on the server.
CC: @LukasReschke @nickvergessen @MorrisJobke @icewind1991