fix: Create new files on public pages for 31+#4794
Conversation
juliusknorr
force-pushed
the
fix/create-file-public
branch
3 times, most recently
from
6e49c7c to
4de0292
Compare
|
Until we can implement something in the server to support this, it seems fine enough. I gave it some testing, and I have a few things to mention: 1. I noticed that the "New folder" button appears in between the other buttons, so it looks a bit strange: 2. The template picker does not take template fields into account or show a template filler. Since this would need to be implemented ourselves here until there is proper support on the server, I am assuming this not worth it, but just want to confirm. 3. If there is no template to choose from, the file is simply created and the name is auto-incremented, without actually asking the guest user to enter a name for the file. Is this expected? |
juliusknorr
force-pushed
the
fix/create-file-public
branch
from
4de0292 to
3721b53
Compare
|
Thanks a lot, much appreciated. I pushed a fix for the ordering, the rest I would leave to the server implementation as it mainly restores previous behaviour now. |
juliusknorr
added
bug
Signed-off-by: Julius Knorr <[email protected]>
Signed-off-by: Julius Knorr <[email protected]>
… links Signed-off-by: Julius Knorr <[email protected]>
juliusknorr
force-pushed
the
fix/create-file-public
branch
from
3721b53 to
7d181a9
Compare
elzody
left a comment
elzody
left a comment
There was a problem hiding this comment.
Indeed, in that case it looks fine to just restore the capability.
github-project-automation
bot
moved this from 👀 In review
to ☑️ Done
in 📝 Productivity team
|
@elzody is there a reason to not backport this to stable31? |
|
@grnd-alt You're right, it probably should have been. I will look into it |
|
/backport to stable31 |
3 participants
This is probably a hotfix for nextcloud/server#48064
Fix #3170
I thought it would be a quick way to bring back the old methods until we have time to dig into implementing this as a generic mechanism in server
It still needs