feat: Add option to set secure view for public talk shares#4772
Merged
juliusknorr merged 4 commits intomainfrom May 26, 2025
Merged
feat: Add option to set secure view for public talk shares#4772juliusknorr merged 4 commits intomainfrom
juliusknorr merged 4 commits intomainfrom
Conversation
juliusknorr
force-pushed
the
feat/secure-view-talk
branch
2 times, most recently
from
195c1fc to
09e7457
Compare
This comment was marked as resolved.
This comment was marked as resolved.
juliusknorr
force-pushed
the
feat/secure-view-talk
branch
from
58a8fc7 to
6707066
Compare
juliusknorr
force-pushed
the
feat/secure-view-talk
branch
from
6707066 to
4c25ddd
Compare
Member
Author
|
/backport to stable31 |
juliusknorr
commented
May 21, 2025
| <licence>agpl</licence> | ||
| <author>Collabora Productivity based on work of Frank Karlitschek, Victor Dubiniuk</author> | ||
| <types> | ||
| <filesystem /> |
Member
Author
There was a problem hiding this comment.
We dropped this with #1728 in the past due to performance impact, but this is no longer a problem since the whole Application.php is now only using lazy registration methods
Signed-off-by: Julius Knorr <[email protected]>
Signed-off-by: Julius Knorr <[email protected]>
Signed-off-by: Julius Knorr <[email protected]>
juliusknorr
force-pushed
the
feat/secure-view-talk
branch
from
ee0e21d to
6606240
Compare
juliusknorr
force-pushed
the
feat/secure-view-talk
branch
4 times, most recently
from
25d80ef to
92c8d70
Compare
…ecure view in talk shares Signed-off-by: Julius Knorr <[email protected]>
juliusknorr
force-pushed
the
feat/secure-view-talk
branch
from
92c8d70 to
37b3729
Compare
elzody
approved these changes
May 24, 2025
github-project-automation
bot
moved this from 🏗️ In progress
to ☑️ Done
in 📝 Productivity team
Member
Author
|
/backport to stable31 |
2 tasks
|
The backport to # Switch to the target branch and update it
git checkout stable31
git pull origin stable31
# Create the new backport branch
git checkout -b backport/4772/stable31
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 9bd20206 c13e6583 0076f564 37b37299
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/4772/stable31Error: Failed to create pull request: Validation Failed: {"resource":"PullRequest","code":"custom","message":"A pull request already exists for nextcloud:backport/4772/stable31."} - https://docs.github.com/rest/pulls/pulls#create-a-pull-request Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Julius Knorr [email protected]
Summary
TODO
Checklist