fix: check if template fields should be extracted#4713
Merged
juliusknorr merged 2 commits intomainfrom May 27, 2025
Merged
Conversation
4 tasks
elzody
force-pushed
the
fix/templates-loading
branch
from
153be00 to
045926a
Compare
elzody
force-pushed
the
fix/templates-loading
branch
from
045926a to
aaaafb6
Compare
github-project-automation
bot
moved this to 🧭 Planning evaluation (don't pick)
in 📝 Productivity team
elzody
moved this from 🧭 Planning evaluation (don't pick)
to 🏗️ In progress
in 📝 Productivity team
Member
|
This is obsolete with the slightly different approach in nextcloud/server#52514, right? |
elzody
force-pushed
the
fix/templates-loading
branch
from
aaaafb6 to
daa73bf
Compare
Collaborator
Author
|
@juliusknorr Not necessarily. We still need to check |
elzody
force-pushed
the
fix/templates-loading
branch
from
daa73bf to
cc38527
Compare
elzody
added
3. to review
juliusknorr
reviewed
May 23, 2025
juliusknorr
requested changes
May 23, 2025
Member
juliusknorr
left a comment
juliusknorr
left a comment
There was a problem hiding this comment.
Small addition to account for compatibility, but otherwise 👍
The `BeforeGetTemplatesEvent` now has a property that allows us to check if the templates should be enhanced with fields or not. If so, then we extract the fields, if not, simply do not. Signed-off-by: Elizabeth Danzberger <[email protected]>
elzody
force-pushed
the
fix/templates-loading
branch
from
cc38527 to
770287f
Compare
Signed-off-by: Elizabeth Danzberger <[email protected]>
elzody
changed the title
elzody
changed the title
juliusknorr
approved these changes
May 27, 2025
github-project-automation
bot
moved this from 👀 In review
to ☑️ Done
in 📝 Productivity team
Member
|
/backport to stable31 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
With the new server changes, we need to check if the event tells us to fetch the fields or not. If the fields should be extracted, then we do that. On the server side, this will only be triggered once the user makes a template selection, and only that template will be sent.
The documentation has been updated for the server pull request, and the
templates.spec.jstests have been expanded a bit in this pull request to verify that no template fields are extracted at first.Checklist