Pass data to field depending on field type#3919
Merged
juliusknorr merged 3 commits intomainfrom Aug 28, 2024
Merged
Conversation
elzody
added
enhancement
This was referenced Aug 20, 2024
elzody
force-pushed
the
feat/checkbox-template-field-type
branch
from
a875e0d to
a51bce3
Compare
elzody
force-pushed
the
feat/checkbox-template-field-type
branch
from
a4d3de4 to
a811e61
Compare
…field types Signed-off-by: Elizabeth Danzberger <[email protected]>
elzody
force-pushed
the
feat/checkbox-template-field-type
branch
from
a811e61 to
26a2b4b
Compare
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
juliusknorr
approved these changes
Aug 28, 2024
Member
|
/backport to stable30 |
Closed
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR reworks the
TemplateFieldServiceclass a bit to add attributes to the field depending on the type of field it is. This is part of #3917 and would be needed for nextcloud/server#47290 if it's a reasonable approach.Checklist