Skip to content

Comments

Prevent not-needed early loading of the richdocuments app#1728

Merged
artonge merged 1 commit intomasterfrom
techdept/noid/prevent-early-loading
Sep 1, 2021
Merged

Prevent not-needed early loading of the richdocuments app#1728
artonge merged 1 commit intomasterfrom
techdept/noid/prevent-early-loading

Conversation

@juliusknorr
Copy link
Member

There is no need to register the filesystem/dav types for the app so we can avoid loading it too early

@artonge
Copy link
Contributor

artonge commented Aug 30, 2021

@juliusknorr
Copy link
Member Author

Sure, the types are used to load groups of certain apps earlier than others.

E.g. authentication apps should be available as early as possible:
https://github.com/nextcloud/server/blob/b78f3a57d1d05fb5f81ec8361139b64a3e54d7b0/lib/base.php#L979

filesystem apps are loaded before all others with https://github.com/nextcloud/server/blob/b78f3a57d1d05fb5f81ec8361139b64a3e54d7b0/lib/base.php#L997 so their application bootstrap is ran early as well.

There was no concrete error case in the Collabora integration but you might want to have a look at the description in ONLYOFFICE/onlyoffice-nextcloud#511 (comment) for a bug caused by the too early loading in combination with the guests app ONLYOFFICE/onlyoffice-nextcloud#511 (comment)

Copy link
Contributor

@artonge artonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, thanks, totally reversed the way I first understood it :)
Makes sense.

@artonge artonge merged commit db5a84d into master Sep 1, 2021
@delete-merged-branch delete-merged-branch bot deleted the techdept/noid/prevent-early-loading branch September 1, 2021 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants