Skip to content

feat(Settings): Refine settings components#3327

Merged
artonge merged 6 commits into
masterfrom
artonge/feat/follow_up_new_form_components
Nov 20, 2025
Merged

feat(Settings): Refine settings components#3327
artonge merged 6 commits into
masterfrom
artonge/feat/follow_up_new_form_components

Conversation

@artonge
Copy link
Copy Markdown
Collaborator

@artonge artonge commented Nov 20, 2025 •
edited
Loading

  1. Use full width button for sources
  2. Merge upload folders info into a single button
  3. Re-arrange setting groups and order.
Before After
image image

@artonge artonge self-assigned this Nov 20, 2025
@artonge artonge added enhancement New feature or request 3. to review Waiting for reviews javascript Javascript related ticket labels Nov 20, 2025
@artonge artonge added this to the Nextcloud 33 milestone Nov 20, 2025
@artonge artonge changed the title fix(Settings): Refine settings components feat(Settings): Refine settings components Nov 20, 2025
@artonge artonge force-pushed the artonge/feat/follow_up_new_form_components branch from 6ac452b to 902dd0c Compare November 20, 2025 11:26
@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 20, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@artonge artonge requested a review from kra-mo November 20, 2025 11:29
@artonge artonge mentioned this pull request Nov 20, 2025
Merged
@artonge artonge force-pushed the artonge/feat/follow_up_new_form_components branch 5 times, most recently from 1e039a7 to 80d803d Compare November 20, 2025 11:43
kra-mo
kra-mo approved these changes Nov 20, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@kra-mo kra-mo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you :)

Some smaller comments/suggestions:

  • It would be nice if the icon for choosing a folder would be consistent with the one in Talk etc.
  • The text beneath Media folders is now misaligned. Is this due to a library update? Regardless, it should be fixed.
  • In any case, I feel like all settings could be reorganized under just one "General" pane since the app doesn't have a lot. This is for the future, where if an app only has one main settings section, the navigation sidebar will be hidden.
  • I would also make some wording changes.
Image

@kra-mo
Copy link
Copy Markdown
Member

kra-mo commented Nov 20, 2025 •
edited
Loading

Oh actually, showNavigation is an existing property. It can just manually be set to false if there is only one section, I suppose.

@artonge artonge force-pushed the artonge/feat/follow_up_new_form_components branch from 80d803d to 3e07287 Compare November 20, 2025 11:56
@artonge
Copy link
Copy Markdown
Collaborator Author

artonge commented Nov 20, 2025 •
edited
Loading

Oh actually, showNavigation is an existing property. It can just manually be set to false if there is only one section, I suppose.

So the idea was to hide the sidebar, not to remove the sections titles?

@kra-mo
Copy link
Copy Markdown
Member

kra-mo commented Nov 20, 2025

Oh actually, showNavigation is an existing property. It can just manually be set to false if there is only one section, I suppose.

So the idea was to hide the sidebar, not to remove the sections titles?

Both :)

Since the sections were so small and there were so few of them

kra-mo
kra-mo requested changes Nov 20, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@kra-mo kra-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, it looks really nice now :)

I only have this comment about the period, and there is the hiding of the sidebar.

Comment thread src/components/Settings/PhotosSourceLocationsSettings.vue Outdated
@artonge artonge force-pushed the artonge/feat/follow_up_new_form_components branch 2 times, most recently from f9220d1 to 12baac1 Compare November 20, 2025 13:18
@artonge artonge requested a review from kra-mo November 20, 2025 13:21
@artonge
Copy link
Copy Markdown
Collaborator Author

artonge commented Nov 20, 2025

/compile /

@artonge artonge force-pushed the artonge/feat/follow_up_new_form_components branch from a7aa912 to e812de0 Compare November 20, 2025 15:38
@artonge
Copy link
Copy Markdown
Collaborator Author

artonge commented Nov 20, 2025

/compile /

@nextcloud-command
chore(assets): Recompile assets
d96df2c 
Signed-off-by: nextcloud-command <[email protected]>
@artonge artonge merged commit 39ec8bf into master Nov 20, 2025
48 of 50 checks passed
@artonge artonge deleted the artonge/feat/follow_up_new_form_components branch November 20, 2025 17:34
@artonge
Copy link
Copy Markdown
Collaborator Author

artonge commented Nov 20, 2025

Thanks for the many inputs @kra-mo !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kra-mo kra-mo kra-mo approved these changes

Assignees

@artonge artonge

Labels

3. to review Waiting for reviews enhancement New feature or request javascript Javascript related ticket

Projects

None yet

Milestone

Nextcloud 33

Development

Successfully merging this pull request may close these issues.

3 participants

@artonge @kra-mo @nextcloud-command