Skip to content

Comments

fix(Album): Stop replacing navigation button#3287

Merged
artonge merged 1 commit intomasterfrom
artonge/fix/album_navigation_button
Nov 13, 2025
Merged

fix(Album): Stop replacing navigation button#3287
artonge merged 1 commit intomasterfrom
artonge/fix/album_navigation_button

Conversation

@artonge
Copy link
Collaborator

@artonge artonge commented Nov 13, 2025 •
edited
Loading

This does not make sense, and work badly on mobile.

Issues were:

  • User could not toggle the sidebar in the album content view
  • User could no got back from the album content view with the sidebar open
  • The sidebar button was not re-enabled when leaving the album content view
View Before After
Sidebar open image image
Sidebar closed image image

@artonge
fix(Album): Stop replacing navigation button
5bac283 
This does not make sense, and work badly on mobile.

Signed-off-by: Louis Chmn <[email protected]>
@artonge artonge self-assigned this Nov 13, 2025
@artonge artonge requested review from skjnldsv and susnux November 13, 2025 17:18
@artonge artonge added bug Something isn't working 3. to review Waiting for reviews javascript Javascript related ticket feature: albums Related to the albums section labels Nov 13, 2025
@artonge artonge added this to the Nextcloud 33 milestone Nov 13, 2025
@artonge
Copy link
Collaborator Author

artonge commented Nov 13, 2025

/backport to stable32

@artonge
Copy link
Collaborator Author

artonge commented Nov 13, 2025

/backport to stable31

@backportbot backportbot bot added the backport-request Pending backport by the backport-bot label Nov 13, 2025
@artonge
Copy link
Collaborator Author

artonge commented Nov 13, 2025

/backport to stable30

@artonge
Copy link
Collaborator Author

artonge commented Nov 13, 2025

/backport to stable29

@codecov
Copy link

codecov bot commented Nov 13, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 2.21%. Comparing base (5a5f809) to head (5bac283).
⚠️ Report is 10 commits behind head on master.

Additional details and impacted files 
@@          Coverage Diff           @@
##           master   #3287   +/-   ##
======================================
  Coverage    2.21%   2.21%           
======================================
  Files         107     107           
  Lines        6586    6579    -7     
  Branches      121     121           
======================================
  Hits          146     146           
+ Misses       6435    6428    -7     
  Partials        5       5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@artonge
Copy link
Collaborator Author

artonge commented Nov 13, 2025

Force merging, tests are green, only missing build files, but will compile them in a follow-up

@artonge artonge merged commit fa725e9 into master Nov 13, 2025
45 of 47 checks passed
@artonge artonge deleted the artonge/fix/album_navigation_button branch November 13, 2025 21:59
This was referenced Nov 13, 2025
Merged
Merged
Merged
Merged
@backportbot backportbot bot removed the backport-request Pending backport by the backport-bot label Nov 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@susnux susnux susnux approved these changes

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees

@artonge artonge

Labels

3. to review Waiting for reviews bug Something isn't working feature: albums Related to the albums section javascript Javascript related ticket

Projects

None yet

Milestone

Nextcloud 33

Development

Successfully merging this pull request may close these issues.

2 participants

@artonge @susnux