fix: close sidebar on navigation change#3113
Conversation
skjnldsv
commented
Jul 28, 2025
skjnldsv
commented
- Keep the sidebar opened if the only thing we did was closing the viewer
- But close the sidebar if we clic another entry on the navigation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3113 +/- ##
=========================================
- Coverage 2.29% 2.29% -0.01%
=========================================
Files 108 108
Lines 6405 6409 +4
Branches 122 122
=========================================
Hits 147 147
- Misses 6253 6257 +4
Partials 5 5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: skjnldsv <[email protected]>
skjnldsv
force-pushed
the
fix/sidebar-close-nav-change
branch
from
597d7bd to
5e9e7b4
Compare
|
/compile |
|
/backport to stable31 |
|
/backport to stable30 |
Signed-off-by: nextcloud-command <[email protected]>
|
The backport to # Switch to the target branch and update it
git checkout stable30
git pull origin stable30
# Create the new backport branch
git checkout -b backport/3113/stable30
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 5e9e7b44 bc2a0f94
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/3113/stable30Error: Failed to check for changes with origin/stable30: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
|
The backport to # Switch to the target branch and update it
git checkout stable31
git pull origin stable31
# Create the new backport branch
git checkout -b backport/3113/stable31
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 5e9e7b44 bc2a0f94
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/3113/stable31Error: Failed to check for changes with origin/stable31: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
3 participants
