Skip to content

Comments

[stable31] fix(perf): Do not request faces properties in search requests#3030

Merged
artonge merged 1 commit intostable31from
artonge/fix/do_not_requestfaces_props_in_search
May 22, 2025
Merged

[stable31] fix(perf): Do not request faces properties in search requests#3030
artonge merged 1 commit intostable31from
artonge/fix/do_not_requestfaces_props_in_search

Conversation

@artonge
Copy link
Collaborator

@artonge artonge commented May 21, 2025

stable31 only as 32 got fixed in the modernisation work.

@artonge artonge force-pushed the artonge/fix/do_not_requestfaces_props_in_search branch from 29d51f0 to f0899ef Compare May 21, 2025 10:31
@artonge artonge changed the title fix(perf): Do not request faces related property in search requests fix(perf): Do not request faces properties in search requests May 21, 2025
@artonge
Copy link
Collaborator Author

artonge commented May 21, 2025

/backport to stable30

@artonge
Copy link
Collaborator Author

artonge commented May 21, 2025

/backport to stable29

@backportbot backportbot bot added the backport-request Pending backport by the backport-bot label May 21, 2025
@artonge artonge self-assigned this May 21, 2025
@artonge artonge added 3. to review Waiting for reviews javascript Javascript related ticket performance 🚀 Performance issues and optimisations labels May 21, 2025
@artonge artonge added this to the Nextcloud 31.0.6 milestone May 21, 2025
@artonge artonge requested a review from juliusknorr May 21, 2025 10:32
@artonge artonge force-pushed the artonge/fix/do_not_requestfaces_props_in_search branch from f0899ef to 2126aa7 Compare May 21, 2025 10:50
@artonge
Copy link
Collaborator Author

artonge commented May 21, 2025

/compile amend /

Signed-off-by: Louis Chemineau <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
@nextcloud-command nextcloud-command force-pushed the artonge/fix/do_not_requestfaces_props_in_search branch from 2126aa7 to bdc057d Compare May 21, 2025 11:39
@artonge artonge requested a review from susnux May 22, 2025 12:45
@artonge artonge changed the title fix(perf): Do not request faces properties in search requests [stable31] fix(perf): Do not request faces properties in search requests May 22, 2025
@susnux
Copy link
Contributor

susnux commented May 22, 2025

Makes sense, in general the current way with nc files is too broad, we need also for the files app not only one way of requesting props but to have standard props and only-per-request props.
E.g. the rich workspace is such a property.

@artonge artonge merged commit b5df4fd into stable31 May 22, 2025
46 checks passed
@artonge artonge deleted the artonge/fix/do_not_requestfaces_props_in_search branch May 22, 2025 13:52
@backportbot
Copy link

backportbot bot commented May 22, 2025

The backport to stable29 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable29
git pull origin stable29

# Create the new backport branch
git checkout -b backport/3030/stable29

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick bdc057d6

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/3030/stable29

Error: Failed to check for changes with origin/stable29: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot
Copy link

backportbot bot commented May 22, 2025

The backport to stable30 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable30
git pull origin stable30

# Create the new backport branch
git checkout -b backport/3030/stable30

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick bdc057d6

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/3030/stable30

Error: Failed to check for changes with origin/stable30: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews backport-request Pending backport by the backport-bot javascript Javascript related ticket performance 🚀 Performance issues and optimisations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants