Conversation
Signed-off-by: Louis Chemineau <[email protected]>
Signed-off-by: Louis Chemineau <[email protected]>
artonge
added
3. to review
artonge
force-pushed
the
artonge/chore/use_vite
branch
2 times, most recently
from
844b366 to
dc13cc5
Compare
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
artonge
force-pushed
the
artonge/chore/use_vite
branch
2 times, most recently
from
22c1cbd to
db43d2f
Compare
Signed-off-by: Louis Chemineau <[email protected]>
Signed-off-by: Louis Chemineau <[email protected]>
Signed-off-by: Louis Chemineau <[email protected]>
artonge
force-pushed
the
artonge/chore/use_vite
branch
2 times, most recently
from
757ffa3 to
42c1565
Compare
Signed-off-by: Louis Chemineau <[email protected]>
artonge
force-pushed
the
artonge/chore/use_vite
branch
from
42c1565 to
5b64e48
Compare
This was referenced Apr 10, 2025
susnux
reviewed
Apr 23, 2025
Contributor
There was a problem hiding this comment.
not needed with vite anymore (as you also replaced jest with vitest)
susnux
reviewed
Apr 23, 2025
| @@ -90,29 +91,24 @@ | |||
| "@nextcloud/cypress": "^1.0.0-beta.12", | |||
Contributor
There was a problem hiding this comment.
babel config above not needed anymore
Contributor
There was a problem hiding this comment.
(if cypress is also using vite)
skjnldsv
approved these changes
Apr 23, 2025
susnux
approved these changes
Apr 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minimal changes to switch to vite.
Better reviewed per commit.