Prevent error on generating thumbnails#1834
Prevent error on generating thumbnails#1834adriano-pinaffo wants to merge 1 commit intonextcloud:masterfrom
Conversation
|
I've recently fixed a bug in recognize that would cause this, so this might not be necessary, but we can add it for good measure. |
|
@marcelklehr can you point to the fix and @adriano-pinaffo can you check if this fix the issue for you? |
|
here you go: nextcloud/recognize@0fdb558 |
|
@artonge @marcelklehr it seems it won't fix the issue because my FacePhoto.php's |
|
@adriano-pinaffo Could you disable recognize to check whether this bug stems from recognize then? |
|
@marcelklehr I had this issue with Photos before installing Memories. Since installing Memories I am able to view the photos there but not in the Photos app. It might be useful to note, that I only started to get this issue in Photos after I ran |
|
Update: I fixed it by running |
|
@artonge what do you think still needed or fixed and can be closed? |
|
The code has changed since then. I don't see how the error could occur at the time, and don't see how it could occur now. Feel free to reopen if needed. |


When generating the thumbnails the parsing throws an error if the file property representing the image size metadata is an empty string. This protects the string by making it be a
"{}"if the string is empty. This is described in #1833.